Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undmg: 1.0.5 -> 1.1.0 #95825

Merged
merged 2 commits into from Aug 20, 2020
Merged

undmg: 1.0.5 -> 1.1.0 #95825

merged 2 commits into from Aug 20, 2020

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
undmg: 1.0.5 -> 1.1.0
4694b67
@matthewbauer
undmg: use file name instead of pipe
e57df58 
There’s some issue in really big files with pipes that doesn’t occur
in filename decompression.
drewrisinger
drewrisinger approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review:
https://github.com/NixOS/nixpkgs/pull/95825
4 packages failed to build:
linuxPackages_4_14.prl-tools linuxPackages_4_4.prl-tools linuxPackages_4_9.prl-tools zandronum

2 packages built:
fmodex undmg

All failed packages also fail on master.

@danieldk danieldk merged commit 345c44d into NixOS:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @drewrisinger @danieldk