Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtwebengine: fix build for darwin #95826

Merged
merged 1 commit into from Aug 21, 2020
Merged

qtwebengine: fix build for darwin #95826

merged 1 commit into from Aug 21, 2020

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Aug 20, 2020

Motivation for this change

I want to use software on macOS that depends on this, like Anki.

Resolves #76715
Resolves #86949

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eqyiel eqyiel requested a review from ttuegel as a code owner August 20, 2020 00:58
@JJJollyjim
Copy link
Member

Testing now (the build takes a while :)

veprbl
veprbl approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review on x86_64-darwin

15 package marked as broken and skipped:
ankisyncd deepin.qt5integration deepin.qt5platform-plugins melonDS nmon pysolfc qsynth qt-mobility qt-video-wlr qt3 qt4 qt5ct qtads quvi quvi_scripts

20 package failed to build:
anki mellowplayer merkaartor mnemosyne nmapsi4 plex-media-player python-qt python27Packages.pyside2 python27Packages.pyside2-tools python37Packages.pyside2 python37Packages.pyside2-tools python38Packages.pyside2 python38Packages.pyside2-tools qsyncthingtray qt5.full qt514.full qt514.qtwebengine qt514.qtwebview qutebrowser sl1-to-photon

7 package built:
ghostwriter python27Packages.pyqtwebengine python37Packages.pyqtwebengine python38Packages.pyqtwebengine qt5.qtwebengine qt5.qtwebview webmacs

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde labels Aug 20, 2020
@ofborg ofborg bot requested a review from matthewbauer August 20, 2020 11:33
@veprbl veprbl merged commit ddea9ac into NixOS:master Aug 21, 2020
@eqyiel eqyiel deleted the fix/make-qtwebengine-build-on-darwin branch August 22, 2020 05:45
@eqyiel
Copy link
Contributor Author

eqyiel commented Aug 22, 2020

@NixOS/darwin-maintainers what's the process for getting this in the https://hydra.nixos.org/jobset/nixpkgs/nixpkgs-20.03-darwin jobset? Does it require manual intervention? 👀

@veprbl
Copy link
Member

veprbl commented Aug 22, 2020

@eqyiel That would require this change to be backported to "release-20.03" branch first. If you can, please open another PR against that branch, will need to test it again. The commit will need to be cherry-picked with "-x" option, as documented in https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches .

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 22, 2020
@eqyiel
Copy link
Contributor Author

eqyiel commented Aug 23, 2020

@veprbl thank you, I tried it but after cherry-picking to the head of that branch, qtwebengine doesn't build because qtbase does not build: 😢

Qt is now configured for building. Just run 'make'.
Once everything is built, you must run 'make install'.
Qt will be installed into '/nix/store/sd1f5wr2j54wcmjf6p9pl815jvp4bz9d-qtbase-5.12.7'.

Prior to reconfiguration, make sure you remove any leftovers from
the previous build.

Project ERROR:
Could not resolve SDK product version for 'macosx'.

I don't have time to investigate right now but looks like porting this to stable would require some other changes to be cherry-picked.

@veprbl
Copy link
Member

veprbl commented Aug 23, 2020

@eqyiel Are you sure about qtbase? It seems to build just fine on Hydra currently: https://hydra.nixos.org/job/nixpkgs/nixpkgs-20.03-darwin/qt512.qtbase.x86_64-darwin

@veprbl
Copy link
Member

veprbl commented Aug 23, 2020

Could not resolve SDK product version for 'macosx'.

I suspect, this might be a consequence of not overwriting find_sdk.py and sdk_info.py.

@eqyiel eqyiel mentioned this pull request Aug 24, 2020
Merged
10 tasks
@eqyiel
Copy link
Contributor Author

eqyiel commented Aug 24, 2020

@veprbl sorry, I must have used the wrong nixpkgs checkout at that time because when I double checked, it builds fine. #96130

@sikmir
Copy link
Member

sikmir commented Sep 1, 2020

Build failed for me with:

$ nix-build -A qt5.qtwebengine
...
Using Xcode version , but at least version 8.3.3 is required to build Qt WebEngine.
QtWebEngine will not be built.
...

But I have Xcode 10.1:

$ xcodebuild -version
Xcode 10.1
Build version 10B61

What is going wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QT Webengine fails to compile on MacOS qt5.qtwebengine is broken on macOS
4 participants
@eqyiel @JJJollyjim @veprbl @sikmir