pythonPackages.aioitertools: init at 0.7.0 #95828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 21, 2020
|
please squash the commits, also i sorted python-packages, please rebase on the lastest master |
|
Strange, the whole rebase is totally different order now. |
CMCDragonkai
force-pushed
the
aioitertools
branch
2 times, most recently
from
7e8aae9
to
ca19b8c
Compare
CMCDragonkai
force-pushed
the
aioitertools
branch
from
ca19b8c
to
fa2bc8d
Compare
|
Done. |
jonringer
reviewed
Sep 4, 2020
Comment on lines
+183
to
+184
| aioitertools = callPackage ../development/python-modules/aioitertools { }; | ||
|
|
There was a problem hiding this comment.
this should be further down, specifically, after the aioh entries
Co-authored-by: Jon <jonringer@users.noreply.github.com>
Co-authored-by: Jon <jonringer@users.noreply.github.com>
Co-authored-by: Jon <jonringer@users.noreply.github.com>
|
|
||
| buildPythonPackage rec { | ||
| pname = "aioitertools"; | ||
| version = "0.7.0"; |
There was a problem hiding this comment.
Suggested change
| version = "0.7.0"; | |
| version = "0.7.1"; |
aioitertools has since been updated on pypi
|
|
||
| meta = with lib; { | ||
| homepage = "https://github.com/omnilib/aioitertools"; | ||
| description = "Implementation of itertools, builtins, and more for AsyncIO and mixed-type iterables."; |
There was a problem hiding this comment.
Suggested change
| description = "Implementation of itertools, builtins, and more for AsyncIO and mixed-type iterables."; | |
| description = "Implementation of itertools, builtins, and more for AsyncIO and mixed-type iterables"; |
|
Can you squash the commits together? |
| ]; | ||
|
|
||
| checkPhase = '' | ||
| ${python.interpreter} -m aioitertools.tests |
There was a problem hiding this comment.
Python is undefined here.
|
Feel free to take over the PR. I don't have time for this atm. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Added aioitertools for Python asyncio based itertools.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)