Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Androidenv update #95805

Closed
wants to merge 2 commits into from
Closed

Androidenv update #95805

wants to merge 2 commits into from

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Aug 19, 2020

Motivation for this change

Relies on this PR - #95804
Ran the generate.sh script to update the generated/ files.`

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthewbauer
matthewbauer reviewed Aug 19, 2020
View reviewed changes
pkgs/development/mobile/androidenv/generated/system-images-android.nix
sha1 = "e0e6504734f601c28350528d39a4b17b3e0f82dc";
};
};
"29".default."x86" = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same attr as the one above. It looks like #95512 is still a problem. I guess we need to tweak generate.sh /cc @svanderburg

matthewbauer
matthewbauer reviewed Aug 19, 2020
View reviewed changes
pkgs/development/mobile/androidenv/generated/system-images-android.nix
revision = "29-default-x86";
displayName = "Intel x86 Atom System Image";
archives.all = fetchurl {
url = "https://dl.google.com/android/repository/sys-img/android/x86-29_r07-darwin.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupe url, and sha1 too

@numinit
Copy link
Contributor

numinit commented Aug 22, 2020

Rewrite to fix the dupe issue for good: #89775

@numinit numinit mentioned this pull request Aug 22, 2020
Merged
10 tasks
@puffnfresh
Copy link
Contributor

Closing in favour of #89775

@puffnfresh puffnfresh closed this Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eyJhb @numinit @puffnfresh @matthewbauer