Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mozwire: 0.4.1 -> 0.5.1 #95830

Merged
merged 1 commit into from Aug 20, 2020
Merged

mozwire: 0.4.1 -> 0.5.1 #95830

merged 1 commit into from Aug 20, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Aug 20, 2020

Motivation for this change

Change hashes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Aug 20, 2020

@GrahamcOfBorg build mozwire

@siraben
Copy link
Member Author

siraben commented Aug 20, 2020

@zowoq

@alyssais
Copy link
Member

Test should either be disabled, or the test that tries to do networking should be skipped.

@siraben
Copy link
Member Author

siraben commented Aug 20, 2020 •
edited

Ok, had a conversation with the maintainer of MozWire and they'll remove the test that needs networking in the next release, then I'll rename the PR and force-push.

NilsIrl added a commit to NilsIrl/MozWire that referenced this pull request Aug 20, 2020
@NilsIrl
Ignore networked tests
d14d127 
This is so that build farms that don't have network access can still run
the other tests.

NixOS/nixpkgs#95830 (comment)
@siraben siraben changed the title mozwire: 0.4.1 -> 0.5.0 mozwire: 0.4.1 -> 0.5.1 Aug 20, 2020
@siraben
Copy link
Member Author

siraben commented Aug 20, 2020

I've made the change to version 0.5.1 and added a newline after the inputs for consistency.

@dywedir
Copy link
Member

dywedir commented Aug 20, 2020

Thanks!

@dywedir dywedir merged commit be9bbf4 into NixOS:master Aug 20, 2020
@siraben siraben deleted the mozwire-v0.5.0 branch August 21, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @alyssais @dywedir