Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osslsigncode: unstable-2019-07-25 -> unstable-2020-08-02 #95814

Merged
merged 1 commit into from Aug 21, 2020
Merged

osslsigncode: unstable-2019-07-25 -> unstable-2020-08-02 #95814

merged 1 commit into from Aug 21, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 19, 2020 •
edited

Motivation for this change

Update to include timestamp verification fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from mmahut August 20, 2020 04:18
@1000101
Copy link
Member

1000101 commented Aug 21, 2020

@GrahamcOfBorg build osslsigncode

1000101
1000101 approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms (darwin is stuck, so I built it on darwin locally - success)
  • ran nix-review without any failures
  • ran and tested the binaries

@mmahut mmahut merged commit f3ff6ad into NixOS:master Aug 21, 2020
@prusnak prusnak deleted the osslsigncode branch August 21, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @1000101 @mmahut