Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-update: install man pages #95835

Merged
merged 1 commit into from Aug 20, 2020
Merged

cargo-update: install man pages #95835

merged 1 commit into from Aug 20, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Add man pages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Br1ght0ne and Gerschtli August 20, 2020 15:41
@danieldk
Copy link
Contributor Author

CC @JohnTitor

JohnTitor
JohnTitor approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cc'ing! I cannot test it on my local right now but the change itself makes sense, feel free to merge it if it works well :) (btw it'd be nice if the ofborg bot also pinged me, maybe I'm not a part of the maintainer team on the org?)

@danieldk danieldk merged commit 90892df into NixOS:master Aug 20, 2020
@danieldk
Copy link
Contributor Author

(btw it'd be nice if the ofborg bot also pinged me, maybe I'm not a part of the maintainer team on the org?)

Seems so. I saw that you already asked about this on Discourse. Maybe someone with the right privileges will get back to it.

@danieldk danieldk deleted the cargo-update-man branch August 20, 2020 20:17
@JohnTitor
Copy link
Member

(btw it'd be nice if the ofborg bot also pinged me, maybe I'm not a part of the maintainer team on the org?)

Seems so. I saw that you already asked about this on Discourse. Maybe someone with the right privileges will get back to it.

Alright, will wait then :)

@Gerschtli
Copy link
Contributor

@JohnTitor you could add yourself as maintainer in this package. This way you get mentioned automatically.

@JohnTitor
Copy link
Member

@Gerschtli I am already:

nixpkgs/pkgs/tools/package-management/cargo-update/default.nix

Line 50 in 8560589

maintainers = with maintainers; [ gerschtli filalex77 johntitor ];

@Gerschtli
Copy link
Contributor

That is strange. Maybe your information in ./maintainers/maintainers-list.nix is outdated.

@danieldk
Copy link
Contributor Author

danieldk commented Aug 21, 2020 •
edited

That is strange. Maybe your information in ./maintainers/maintainers-list.nix is outdated.

Maintainers need to be added to the maintainers team of the GitHub NixOS organization. Otherwise, they are not auto-added as reviewers to PRs. Maintainers were automatically invited to this team, but the invite script has been turned off a while ago, due to problems caused by changes in how GitHub handles invitations. See: https://discourse.nixos.org/t/join-the-package-maintainer-team/3751/37 and NixOS/rfcs#39 .

@Gerschtli
Copy link
Contributor

Ah okay, didn't know that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @JohnTitor @Gerschtli