Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r-modules: bioc and cran update #95836

Merged
merged 1 commit into from Oct 20, 2020
Merged

r-modules: bioc and cran update #95836

merged 1 commit into from Oct 20, 2020

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Aug 20, 2020 •
edited

Motivation for this change

Major motivation was to update Bioconductor from 3.8 to 3.11. Nixpkgs has R 4.0 and the corresponding release for Bioconductor is 3.11 (see https://www.bioconductor.org/about/release-announcements/).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbedo jbedo requested a review from peti as a code owner August 20, 2020 06:48
@jbedo
Copy link
Contributor Author

jbedo commented Sep 21, 2020

Bioconductor is broken without fixing the version match, is there anything further I can do to move this along?

@peti peti merged commit 97d0eb5 into NixOS:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbedo @peti