Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 7.71.1 -> 7.72.0 #95813

Merged
merged 1 commit into from Aug 20, 2020
Merged

curl: 7.71.1 -> 7.72.0 #95813

merged 1 commit into from Aug 20, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Aug 19, 2020

Motivation for this change

Fixes CVE-2020-8231

https://curl.haxx.se/changes.html#7_72_0
https://curl.haxx.se/docs/CVE-2020-8231.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested a review from picnoir August 19, 2020 17:28
@risicle
Copy link
Contributor

risicle commented Aug 19, 2020

It would be good to get this into staging at the same time as my #95763 as it also causes a curl rebuild.

@ofborg ofborg bot requested a review from lovek323 August 20, 2020 03:00
@alyssais alyssais merged commit 157645a into NixOS:staging Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir Awaiting requested review from picnoir

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @risicle @alyssais