Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlterm: enable IME support #95290

Merged
merged 1 commit into from Aug 22, 2020
Merged

mlterm: enable IME support #95290

merged 1 commit into from Aug 22, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Aug 12, 2020 •
edited

Motivation for this change

A core feature of mlterm is its support for a wide range of languages, including
those which use non-alphabetic letters. In order to input such letters on an
alphabetic keyboard, an IME needs to be used. Mlterm supports most of the
popular ones by default, they just need to be visible in the configure phase.

These three are the IMEs supported by both NixOS and mlterm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
mlterm: enable IME support
8011cd7 
A core feature of mlterm is its support for a wide range of languages, including
those which use non-alphabetic letters. In order to input such letters on an
alphabetic keyboard, an IME needs to be used. Mlterm supports most of the
popular ones by default, they just need to be visible in the configure phase.

These three are the IMEs supported by both NixOS and mlterm.
@ofborg ofborg bot requested a review from vrthra August 12, 2020 23:50
@Atemu Atemu requested a review from gebner August 18, 2020 12:50
@Atemu
Copy link
Member Author

Atemu commented Aug 22, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 22, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 22, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@gebner
Copy link
Member

gebner commented Aug 22, 2020

Tested with fcitx.

@gebner gebner merged commit cf39546 into NixOS:master Aug 22, 2020
@Atemu Atemu deleted the mlterm-ime branch August 22, 2020 09:05
@Atemu
Copy link
Member Author

Atemu commented Aug 22, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atemu @gebner