Think this'll need a rebase.

Think this'll need a rebase.

Done!

Builds on macos 10.14.

@ofborg build qemu

Please target master this is not a mass rebuild.

Please target master this is not a mass rebuild.

Done!

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 95274 run on x86_64-darwin 1

</details>
diff --git a/pkgs/development/python-modules/cot/default.nix b/pkgs/development/python-modules/cot/default.nix
index 89e26545d79..0c2bb961290 100644
--- a/pkgs/development/python-modules/cot/default.nix
+++ b/pkgs/development/python-modules/cot/default.nix
@@ -35,9 +35,10 @@ buildPythonPackage rec {
     "TestQCOW2"
     "TestRAW"
     "TestVMDKConversion"
+  ] ++ lib.optionals stdenv.isDarwin [
+    "test_serial_fixup_invalid_host"
   ];
 
-
   # argparse is part of the standardlib
   prePatch = ''
     substituteInPlace setup.py --replace "'argparse'," ""

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 95274 run on x86_64-darwin 1

11 packages marked as broken and skipped:
4 packages failed to build and are new build failures:

• cot: log https://termbin.com/dort
• (python38Packages.cot): log was empty
• python37Packages.cot: log https://termbin.com/59tw
• python39Packages.cot: log https://termbin.com/2jf1

6 packages built:

It builds just fine on my machine.

$ uname -sr
Darwin 19.6.0
$ nixpkgs-review pr 95274
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/95274/head:refs/nixpkgs-review/1
$ git worktree add /Users/misuzu/.cache/nixpkgs-review/pr-95274-3/nixpkgs 5d9a3e2e5a05b979d3953eeeb1a8282b241a1f53
Preparing worktree (detached HEAD 5d9a3e2e5a0)
Updating files: 100% (24008/24008), done.
HEAD is now at 5d9a3e2e5a0 cargo-c: 0.7.0 -> 0.7.1
$ git merge --no-commit c5dd597870e90f2bf9a03c5a61517eab5c145740
Auto-merging pkgs/top-level/all-packages.nix
Auto-merging pkgs/applications/virtualization/qemu/default.nix
Automatic merge went well; stopped before committing as requested
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /Users/misuzu/.cache/nixpkgs-review/pr-95274-3/build.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/95274

11 packages marked as broken and skipped:
alpine-make-vm-image cloud-init cloud-utils multibootusb python37Packages.guestfs python38Packages.guestfs python39Packages.guestfs qemu_xen qemu_xen-light qemu_xen_4_10 qemu_xen_4_10-light

9 packages built:
cot libiscsi out-of-tree python37Packages.cot python39Packages.cot qemu qemu-utils qemu_kvm qemu_test

It builds just fine on my machine.

Do you have sandbox enabled?

It builds just fine on my machine.

Do you have sandbox enabled?

Yes. I have multi-user nix with explicitly enabled sandbox.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 95274 run on x86_64-linux 1

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

virtualboxHeadless:

substituteStream(): WARNING: pattern 'PSHCLFORMATDATA' doesn't match anything in file 'src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc-x11-stubs.cpp'

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 95274 run on x86_64-linux 1

2 packages marked as broken and skipped:
1 package blacklisted:
14 packages failed to build and are new build failures:
34 packages built:
The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

virtualboxHeadless:

aqemu and virtualbox packages are already broken on master and unrelated to this change.