Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pure-ftpd: add patches for CVE-2020-9274, CVE-2020-9365 #95280

Merged
merged 1 commit into from Aug 14, 2020
Merged

pure-ftpd: add patches for CVE-2020-9274, CVE-2020-9365 #95280

merged 1 commit into from Aug 14, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 12, 2020 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-9274
https://nvd.nist.gov/vuln/detail/CVE-2020-9365

Fixes merged to upstream's master but no release yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 12, 2020
@risicle
Copy link
Contributor Author

risicle commented Aug 12, 2020

@GrahamcOfBorg build pure-ftpd

@risicle risicle force-pushed the ris-pure-ftpd-CVE-2020-9274 branch from 42ec7bc to 3dfef67 Compare August 12, 2020 21:05
@risicle risicle changed the title pure-ftpd: add patch for CVE-2020-9274 pure-ftpd: add patches for CVE-2020-9274, CVE-2020-9365 Aug 12, 2020
@risicle
Copy link
Contributor Author

risicle commented Aug 12, 2020

@GrahamcOfBorg build pure-ftpd

@risicle
Copy link
Contributor Author

risicle commented Aug 12, 2020 •
edited

Hold on, actually the CVE-2020-9365 isn't merged yet. Amended patch reference to the commit that they actually merged.

@risicle
pure-ftpd: add patches for CVE-2020-9274, CVE-2020-9365
5b072a4 
Fixes merged to upstream's master but no release yet.
@risicle risicle force-pushed the ris-pure-ftpd-CVE-2020-9274 branch from 3dfef67 to 5b072a4 Compare August 12, 2020 21:19
@mweinelt
Copy link
Member

LGTM.

Result of nixpkgs-review pr 95280 1

1 package built:
- pure-ftpd

@mweinelt mweinelt merged commit cee1971 into NixOS:master Aug 14, 2020
@risicle risicle mentioned this pull request Aug 14, 2020
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @mweinelt @TredwellGit