Implement ValueCastable #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not deprecate UserValue. If you'd rather that be included, let me know and I'll add it, but it seemed easier to review them separately. Likewise it does not move internal usage of UserValue over to ValueCastable. |
`memoized`->`ValueCastable.lowermethod`, `__memoized__`->`__memoized`
whitequark
requested changes
Sep 4, 2020
Co-authored-by: whitequark <whitequark@whitequark.org>
|
That should resolve the |
whitequark
requested changes
Oct 26, 2020
Ravenslofty
reviewed
Oct 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 81.33% 81.39% +0.06%
==========================================
Files 49 49
Lines 6419 6440 +21
Branches 1282 1286 +4
==========================================
+ Hits 5221 5242 +21
Misses 1009 1009
Partials 189 189
Continue to review full report at Codecov.
|
whitequark
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the ValueCastable type as described in #355 .