gnvim: icon support (GDK_PIXBUF_MODULE_FILE) #93706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
SuperSandro2000
requested changes
Nov 29, 2020
| @@ -14,6 +14,7 @@ stdenv.mkDerivation { | |||
| '' else '' | |||
| makeWrapper '${gnvim-unwrapped}/bin/gnvim' "$out/bin/gnvim" \ | |||
| --prefix PATH : "${neovim}/bin" \ | |||
| --set GDK_PIXBUF_MODULE_FILE "${librsvg.out}/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache" \ | |||
There was a problem hiding this comment.
Please do not hardcode versions. This will likely cause break in future updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be better ways of solving this I dont know about, but this seems to work on my pc, while the current package does not.
Motivation for this change
When running gnvim on nixos, i get the following error when autocomplete dropdown opens.
(The dropdown contains icons)
Error { domain: gdk-pixbuf-error-quark, code: 3, message: "Unrecognized image file format" }'Full error here: vhakulinen/gnvim#127 (comment)
Things done
setting GDK_PIXBUF_MODULE_FILE in wrapper fixes the error, so I added:
--set GDK_PIXBUF_MODULE_FILE "${pkgs.librsvg.out}/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache" \to makeWrapper, inspired by whats done here: https://github.com/NixOS/nixpkgs/pull/43421/files
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)