Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake.nix: use lib.extend #93707

Merged
merged 1 commit into from Jul 24, 2020
Merged

flake.nix: use lib.extend #93707

merged 1 commit into from Jul 24, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jul 23, 2020

Motivation for this change

This preserves the nixosSystem function if another flake uses lib.extend itself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @edolstra

@B4dM4n
flake.nix: use lib.extend
74430a8 
This preserves the nixosSystem function if another flake uses lib.extend
itself.
Ma27
Ma27 approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully reproduced the issue and can confirm that this patch fixes it 👍

@Ma27 Ma27 merged commit 9627ef0 into NixOS:master Jul 24, 2020
@B4dM4n B4dM4n deleted the flake-nix-lib-extend branch July 24, 2020 16:24
@roberth roberth mentioned this pull request Jul 13, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @Ma27