Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdlib: 1.6.0 -> 1.6.6 #93752

Closed
wants to merge 1 commit into from
Closed

tdlib: 1.6.0 -> 1.6.6 #93752

wants to merge 1 commit into from

Conversation

SeTSeR
Copy link
Contributor

@SeTSeR SeTSeR commented Jul 24, 2020 •
edited

Motivation for this change

Tdlib version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SeTSeR SeTSeR requested a review from vyorkin July 24, 2020 08:26
@vyorkin
Copy link
Member

vyorkin commented Jul 24, 2020

LGTM, pls go ahead

danieldk
danieldk reviewed Jul 25, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to upstream, these patch releases should not be used:

tdlib/td#913 (comment)

We should add a comment to the src attribute to warn people in the future to not upgrade to anything else than x.y.0 with a link to that issue.

@SeTSeR SeTSeR closed this Aug 15, 2020
@vyorkin
Copy link
Member

vyorkin commented Aug 15, 2020 •
edited

@danieldk Thanks, missed that, yeah, good idea about adding the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@vyorkin vyorkin Awaiting requested review from vyorkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SeTSeR @vyorkin @danieldk