Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tempita: fix sources location #93719

Closed
wants to merge 1 commit into from
Closed

pythonPackages.tempita: fix sources location #93719

wants to merge 1 commit into from

Conversation

RomanSharapov
Copy link

@RomanSharapov RomanSharapov commented Jul 23, 2020 •
edited

Motivation for this change

Addresses the issues brought up in #79207 and finalizing the work
by specifying the correct location for what's look like an abandoned package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tempita: fix sources location for tempita Python lib
ead2d71 
Addresses the issues brought up in NixOS#79207 and finalizing the work
by specifying the correct location for what's look like an abandoned package.

Tempita is abandoned upstream (no release since 2013, website redirects to archive.org),
but sqlalchemy-migrate depends on it.
jonringer
jonringer reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanSharapov thanks for opening your first PR with nixpkgs!

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

pythonPackages.tempita: fix sources location

@RomanSharapov RomanSharapov changed the title tempita: fix sources location for tempita Python lib tempita: fix sources location Aug 3, 2020
@RomanSharapov RomanSharapov changed the title tempita: fix sources location pythonPackages.tempita: fix sources location Aug 3, 2020
@RomanSharapov
Copy link
Author

RomanSharapov commented Aug 3, 2020 •
edited

@RomanSharapov thanks for opening your first PR with nixpkgs!

It's my third one already :)

To comply with [CONTRIBUTING.md]
... the commit message should be:

pythonPackages.tempita: fix sources location

Thanks for pointing this out. Fixed.

@RomanSharapov
Copy link
Author

@jonringer, could you PTAL again?

@RomanSharapov
Copy link
Author

Alright, tempita source code is no longer available on the BitBucket because they dropped support for mercurial repos. I guess I'd need to refactor this PR one more time.

@jonringer
Copy link
Contributor

sounds good. Do they have a mirror? as long as it's an official upstream, not too picky about the source

@SuperSandro2000 SuperSandro2000 added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 29, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft December 29, 2020 02:17
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 29, 2020
SuperSandro2000
SuperSandro2000 reviewed Jan 18, 2021
View reviewed changes
pkgs/development/python-modules/tempita/default.nix
meta = {
homepage = "https://github.com/gjhiggins/tempita";
homepage = "https://bitbucket.org/ianb/tempita";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link is also dead.

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RomanSharapov @jonringer @SuperSandro2000