Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal-typeracer: init at 2.0.2 #93697

Merged
merged 2 commits into from Dec 28, 2020
Merged

terminal-typeracer: init at 2.0.2 #93697

merged 2 commits into from Dec 28, 2020

Conversation

yoctocell
Copy link
Member

@yoctocell yoctocell commented Jul 23, 2020

Motivation for this change

Adds terminal-typeracer, a TUI for typeracer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built successfully with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93697" and the application runs successfully.
Approved.

Welcome to nix!

@yoctocell yoctocell requested a review from sikmir August 5, 2020 09:05
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93697 run on x86_64-linux 1

1 package built:
  • terminal-typeracer

@SuperSandro2000
Copy link
Member

Builds on darwin with the following patch:

diff --git a/pkgs/applications/misc/terminal-typeracer/default.nix b/pkgs/applications/misc/terminal-typeracer/default.nix
index 46ee0807c621..88f5cfefca7c 100644
--- a/pkgs/applications/misc/terminal-typeracer/default.nix
+++ b/pkgs/applications/misc/terminal-typeracer/default.nix
@@ -4,6 +4,8 @@
 , pkg-config
 , openssl
 , sqlite
+, libiconv
+, Security
 }:

 rustPlatform.buildRustPackage rec {
@@ -19,7 +21,7 @@ rustPlatform.buildRustPackage rec {

   cargoSha256 = "0ky8m23fjjbv7fr9776fjczpg0d43jxwnjxjpwz56jpynwnihfkl";

-  buildInputs = [ openssl sqlite ];
+  buildInputs = [ openssl sqlite ] ++ stdenv.lib.optionals stdenv.isDarwin [ libiconv Security ];
   nativeBuildInputs = [ pkg-config ];

   meta = with stdenv.lib; {
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 5d35887d91cf..38b0013e09b9 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -24206,7 +24206,9 @@ in

   twinkle = qt5.callPackage ../applications/networking/instant-messengers/twinkle { };

-  terminal-typeracer = callPackage ../applications/misc/terminal-typeracer { };
+  terminal-typeracer = callPackage ../applications/misc/terminal-typeracer {
+    inherit (darwin.apple_sdk.frameworks) Security;
+  };

   ueberzug = with python3Packages; toPythonApplication ueberzug;

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93697 run on x86_64-linux 1

1 package built:
  • terminal-typeracer

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93697 run on x86_64-darwin 1

1 package built:
  • terminal-typeracer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants