-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
terminal-typeracer: init at 2.0.2 #93697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built successfully with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93697"
and the application runs successfully.
Approved.
Welcome to nix!
Result of 1 package built:
|
Builds on darwin with the following patch: diff --git a/pkgs/applications/misc/terminal-typeracer/default.nix b/pkgs/applications/misc/terminal-typeracer/default.nix
index 46ee0807c621..88f5cfefca7c 100644
--- a/pkgs/applications/misc/terminal-typeracer/default.nix
+++ b/pkgs/applications/misc/terminal-typeracer/default.nix
@@ -4,6 +4,8 @@
, pkg-config
, openssl
, sqlite
+, libiconv
+, Security
}:
rustPlatform.buildRustPackage rec {
@@ -19,7 +21,7 @@ rustPlatform.buildRustPackage rec {
cargoSha256 = "0ky8m23fjjbv7fr9776fjczpg0d43jxwnjxjpwz56jpynwnihfkl";
- buildInputs = [ openssl sqlite ];
+ buildInputs = [ openssl sqlite ] ++ stdenv.lib.optionals stdenv.isDarwin [ libiconv Security ];
nativeBuildInputs = [ pkg-config ];
meta = with stdenv.lib; {
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 5d35887d91cf..38b0013e09b9 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -24206,7 +24206,9 @@ in
twinkle = qt5.callPackage ../applications/networking/instant-messengers/twinkle { };
- terminal-typeracer = callPackage ../applications/misc/terminal-typeracer { };
+ terminal-typeracer = callPackage ../applications/misc/terminal-typeracer {
+ inherit (darwin.apple_sdk.frameworks) Security;
+ };
ueberzug = with python3Packages; toPythonApplication ueberzug; |
Result of 1 package built:
|
Result of 1 package built:
|
Motivation for this change
Adds terminal-typeracer, a TUI for typeracer.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)