smallstep: 0.13.3 -> 0.14.6 #93711
Merged
smallstep: 0.13.3 -> 0.14.6 #93711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build step-cli step-ca |
|
Out of interest, why isn’t the piv-go patch needed for step-cli? piv-go is mentioned in the step-cli go.sum but for all I know this could be stale and not actually used. |
|
Good question. I don't know. Let's have a look before merging. It compiled fine without the dependency |
|
Probably best to regenerate the |
|
Yeah if |
|
@arianvp scrolling through their website, it seems they also provide pam and nss modules for user management. Is this up somewhere too? |
flokli
requested changes
Jul 24, 2020
| # pull in go-piv/piv-go#75 | ||
| # once go-piv/piv-go#75 is merged and released, we should | ||
| # use the released version (and push upstream to do the same) | ||
| patches = [ ../yubikey-agent/use-piv-go-75.patch ]; |
There was a problem hiding this comment.
Getting this from another package is dirty, and considering the version this patch is pointing to breaks darwin (see go-piv/piv-go#75), and piv-go might not be needed at all, let's reach out to upstream on their go.sum file.
There was a problem hiding this comment.
piv-go is needed. Package doesn't build without it.
There was a problem hiding this comment.
Note there are two packages being bumped here. One really requires piv-go
SuperSandro2000
requested changes
Nov 29, 2020
| @@ -1,19 +1,30 @@ | |||
| { lib, buildGoPackage, fetchFromGitHub }: | |||
| { lib, stdenv, pkgconfig, pcsclite, buildGoModule, fetchFromGitHub, darwin }: | |||
There was a problem hiding this comment.
Suggested change
| { lib, stdenv, pkgconfig, pcsclite, buildGoModule, fetchFromGitHub, darwin }: | |
| { lib, stdenv, pkg-config, pcsclite, buildGoModule, fetchFromGitHub, PCSC }: |
Please inerhit PCSC in top-level.nix.
|
Result of 2 packages failed to build:
Please fix the tests with sandbox enabled. |
|
Result of 2 packages failed to build:
|
|
Is this still being worked on? |
|
I'm also interested in this. go-piv/piv-go#75 is included in go-piv/piv-go since v1.6.0, and https://github.com/smallstep/certificates/blob/master/go.mod points to v1.6.0, so this should just work without any patches and the latest release (0.15.6). @arianvp, do you want to update this? |
|
Feel free to continue on this PR @flokli. I'm currently not in the position
where I have time for it.
…On Tue, 22 Dec 2020, 23:42 Florian Klink, ***@***.***> wrote:
I'm also interested in this. go-piv/piv-go#75
<go-piv/piv-go#75> is included in go-piv/piv-go
since v1.6.0, and
https://github.com/smallstep/certificates/blob/master/go.mod points to
v1.6.0, so this should just work without any patches and the latest release
(0.15.6).
@arianvp <https://github.com/arianvp>, do you want to update this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93711 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEZNIYQ7B5Q45DKJVGB26LSWEOGXANCNFSM4PF5QYWQ>
.
|
flokli
force-pushed
the
smallstep-update
branch
from
dcff61c
to
a8f9b96
Compare
|
I pushed a new version addressing all the comments. For Build LogThis has been addressed upstream in smallstep/cli#394, but there's no stable release containing it. Simply applying on top of 0.15.3 also doesn't work, so I moved this to the commit introducing the fix. |
flokli
force-pushed
the
smallstep-update
branch
from
a8f9b96
to
3ded5d4
Compare
SuperSandro2000
requested changes
Dec 23, 2020
| }; | ||
|
|
||
| goDeps = ./deps.nix; |
There was a problem hiding this comment.
That file should be deleted.
|
Result of 2 packages built:
|
|
Result of 1 package failed to build:
1 package built:
|
Co-Authored-By: Florian Klink <flokli@flokli.de>
Co-Authored-By: Florian Klink <flokli@flokli.de>
flokli
force-pushed
the
smallstep-update
branch
from
3ded5d4
to
6e7fb7d
Compare
marsam
approved these changes
Dec 26, 2020
|
@marsam shouldn't we disable the tests on darwin, or mark it as broken there? |
|
Given what the error is, it may just need that one Darwin networking flag to be set. |
|
It builds on darwin, the error shown is because nixpkgs-review uses sandboxed builds and the tests fail wanting networking with loopback (allowed on sanbox). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the same workaround as yubikey-agent. Namely build with
go-piv/piv-go#75 to make piv-go build properly
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)