Skip to content

osqp: init at 0.6.0 #93703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

osqp: init at 0.6.0 #93703

merged 1 commit into from
Aug 20, 2020
+29 −0

Conversation

taktoa
Copy link
Member

@taktoa taktoa commented Jul 23, 2020

Motivation for this change

Packaged a quadratic programming solver for NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • Vacuously true, as this is a new package
  • Tested execution of all binary files (usually in ./result/bin/)
    • Vacuously true, as this is a library, and does not have any executables
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 23, 2020
drewrisinger
drewrisinger suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about version & platforms chosen. Formatting fixes.

  • Diff needs fixes
  • Commits mostly good, might need to change version name
  • Builds via nix-review

Sorry, something went wrong.

@taktoa taktoa changed the title osqp: init at 2020-07-17 osqp: init at unstable-2020-07-17 Jul 24, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jul 24, 2020
drewrisinger
drewrisinger suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits need squashed together (git rebase -i master, then change the later commits from "pick" to "squash"). Change name of "osqp: init at ..." commit to include the new version.
  • Builds via nix-review

Need to address which version to use. Latest tag is 0.6.0, but this uses an untagged version which might be unstable. I have a preference for using the tagged version unless a good reason is given.

Sorry, something went wrong.

@taktoa taktoa changed the title osqp: init at unstable-2020-07-17 osqp: init at 0.6.0 Jul 24, 2020
@taktoa
Copy link
Member Author

taktoa commented Jul 24, 2020

Done

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jul 24, 2020
@taktoa taktoa force-pushed the master branch 2 times, most recently from 4a28c95 to c44996b Compare July 24, 2020 15:22
@taktoa
Copy link
Member Author

taktoa commented Jul 24, 2020

Done

@taktoa taktoa requested a review from drewrisinger July 24, 2020 15:26
drewrisinger
drewrisinger approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review:
https://github.com/NixOS/nixpkgs/pull/93703
1 package built:
osqp

Sorry, something went wrong.

@taktoa taktoa requested a review from sikmir August 8, 2020 21:29
drewrisinger
drewrisinger approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review
  • Review comments from @sikmir addressed
https://github.com/NixOS/nixpkgs/pull/93703
1 package built:
osqp

Sorry, something went wrong.

@infinisil infinisil merged commit 2396252 into NixOS:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger

@sikmir sikmir

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taktoa @sikmir @drewrisinger @infinisil