Fix: GCC warns about possibly uninitialized data in signal.cpp #8281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with
-Og
, GCC warns about variables that are initialized by reference in the condition of awhile
loop.This commit silences the warning by explicitly initializing the variables in question to their respective 'invalid value' markers, which will most likely be optimized out when the compiler realizes the values are never used.
As near as I can tell, the compiler complains because there is a path through
SmallSet::Get
that does not assign to its parameters (i.e. the case of an empty set); and the optimization level in question does not perform the static analysis that would be necessary to determine that the results (or lack thereof) are not actually used in that case.Fixes #8280