Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.jsaddle-warp: Fix build #93710

Merged
merged 1 commit into from Jul 24, 2020
Merged

[haskell-updates] haskellPackages.jsaddle-warp: Fix build #93710

merged 1 commit into from Jul 24, 2020

Conversation

maralorn
Copy link
Member

Disables a patch that is applied on upstream because of new version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
haskellPackages.jsaddle-warp: Fix build
a183c71 
Disables a patch that is applied on upstream because of new version.
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.jsaddle-warp

@maralorn
Copy link
Member Author

test is passing

cdepillabout
cdepillabout approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maralorn maralorn merged this pull request into NixOS:haskell-updates Jul 24, 2020
@maralorn maralorn deleted the jsaddle-warp branch July 24, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout