-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
emacs: Add infrastructure for native-comp #93716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are required for emacs 27 and above and the nix-community emacs overlay are adding these via overrides. Add these already on emacs 26 to be forwards compatible and require less overrides in the overlay.
176d016
to
807e8e0
Compare
8d67a40
to
5f74b92
Compare
Thanks for getting this merged! I just tried building the native-comp emacs on darwin (which I know works outside nix; most instructions refer to homebrew), and found two errors: One is fixed by 3a79681 (which fixes installation of libgccjit), and the other is that https://github.com/NixOS/nixpkgs/pull/93716/files#diff-c88608e19b22610f68cf3cce033c0678R69 depends on |
@antifuchs Do you think you'll have a PR up soon to add Darwin support? I'm having trouble coming up with a fix on my own. |
@evanrelf I'm sorry, I didn't manage to make any progress. There's the Maybe we ought to report one or two other issues about Darwin builds there. /: |
@evanrelf after thinking about this more, here's a branch that seems to build Update, 12 hours later: The change I posted does compile all emacs-gcc's dependencies, but then compilation of emacs itself fails with
|
@antifuchs Could it be because
You probably need to force it to use EDIT: Actually I think I misunderstood the error... it's complaining about |
@evanrelf my understanding is that you have to compile (nextstep-type) Emacs with clang on darwin because gcc hasn't caught up to the language features yet (or you'd have to build it with X11 GUI - see). I think the build dependencies up to libgccjit work, except the libgccjit dynamic library is installed as I guess I have to figure out how to install it as a .dylib... or something else. |
Motivation for this change
This is to facilitate the
emacsGcc
support in https://github.com/nix-community/emacs-overlay.It's not feasible to add all of this through overrides.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)