Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tealdeer: cleanup #93729

Merged
merged 1 commit into from Jul 24, 2020
Merged

tealdeer: cleanup #93729

merged 1 commit into from Jul 24, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jul 24, 2020

Motivation for this change

cacert could have been removed with curl in 11464a5 but I didn't check.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from davidak July 24, 2020 00:37
davidak
davidak approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

works on NixOS

@davidak
Copy link
Member

davidak commented Jul 24, 2020

cacert could have been removed with curl in 11464a5 but I didn't check.

no problem. thanks for your contribution!

@zowoq zowoq merged commit 7b6b361 into NixOS:master Jul 24, 2020
@zowoq zowoq deleted the tealdeer branch July 24, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @davidak