Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chroma: init at 0.8.0 #95361

Merged
merged 1 commit into from Sep 12, 2020
Merged

chroma: init at 0.8.0 #95361

merged 1 commit into from Sep 12, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Add chroma, a syntax highlighting utility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build chroma

@ofborg ofborg bot requested a review from kalbasit August 13, 2020 19:32
doronbehar
doronbehar approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and basic functionality test.

@doronbehar
Copy link
Contributor

Note of self promotion here: Pistol, available on Nixpkgs as pistol is a general purpose file previewer for Unix, with out of the box syntax highlighting based on chroma. and configurable Chroma styles & custom previews based on mime type, or file regex. You might find it more tailored into end user day to day use :).

kalbasit
kalbasit approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments, otherwise LGTM

pkgs/tools/text/chroma/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/chroma/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit August 14, 2020 23:14
stigtsp
stigtsp approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested OK on x86_64-linux

Tested basic functionality of executable

@stigtsp
Copy link
Member

stigtsp commented Sep 12, 2020

@GrahamcOfBorg build chroma

@stigtsp stigtsp merged commit a7e3144 into NixOS:master Sep 12, 2020
@sternenseemann sternenseemann deleted the chroma-0.8.0 branch September 12, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@doronbehar doronbehar doronbehar approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sternenseemann @doronbehar @stigtsp @kalbasit