Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckan 1.16.1 -> 1.29.2 #95372

Merged
merged 1 commit into from Jan 8, 2021
Merged

ckan 1.16.1 -> 1.29.2 #95372

merged 1 commit into from Jan 8, 2021

Conversation

ymarkus
Copy link
Contributor

@ymarkus ymarkus commented Aug 13, 2020

Please review this for MacOS, I'm not sure if my change breaks that.

Motivation for this change

CKAN is heavily out-of-date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lordcirth
Copy link
Contributor

Thanks for doing this! A while ago I spent a few hours trying to get their new build system to work and gave up.

@lordcirth
Copy link
Contributor

lordcirth commented Nov 14, 2020

Can this please be merged? I've been running this out of a manual nix-build from the branch. Also, I think 1.29 is out.

@danieldk danieldk self-requested a review November 15, 2020 09:05
@danieldk
Copy link
Contributor

I don't know enough about .NET packaging or mono. Perhaps @jonringer ?

@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 5, 2021

I had some time to re-review my own request. As of CKAN 1.29.2, it uses Cake to build. As I can't find anything about this in nixpkgs or the documentation, I guess it has to be set up first. Not really worth the hassle if you ask me considering there is a fine EXE in the releases that definitely works fine.
How shall we continue?

@SuperSandro2000
Copy link
Member

I had some time to re-review my own request. As of CKAN 1.29.2, it uses Cake to build. As I can't find anything about this in nixpkgs or the documentation, I guess it has to be set up first. Not really worth the hassle if you ask me considering there is a fine EXE in the releases that definitely works fine.
How shall we continue?

we can use that and patch it if you prefer. The C# support in nix is not that great at this point tbh.

@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 8, 2021

Ok, I've pushed a new commit. We're now going straight to ckan 1.29.2 and using the provided exe. Please check if it was done properly.

Also, @Baughn please check if you still want to be a maintainer for this package or if I shall remove you from the list.

@ymarkus ymarkus changed the title ckan 1.16.1 -> 1.28.0 ckan 1.16.1 -> 1.29.2 Jan 8, 2021
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

@jonringer jonringer merged commit 09b6ca4 into NixOS:master Jan 8, 2021
@jonringer
Copy link
Contributor

I don't know enough about .NET packaging or mono. Perhaps @jonringer ?

We don't really have any Cake support, patching the distributables is fine for now.

@ymarkus ymarkus deleted the ckan-update branch January 9, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants