New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ckan 1.16.1 -> 1.29.2 #95372
ckan 1.16.1 -> 1.29.2 #95372
Conversation
Thanks for doing this! A while ago I spent a few hours trying to get their new build system to work and gave up. |
Can this please be merged? I've been running this out of a manual nix-build from the branch. Also, I think 1.29 is out. |
I don't know enough about .NET packaging or mono. Perhaps @jonringer ? |
I had some time to re-review my own request. As of CKAN 1.29.2, it uses Cake to build. As I can't find anything about this in nixpkgs or the documentation, I guess it has to be set up first. Not really worth the hassle if you ask me considering there is a fine EXE in the releases that definitely works fine. |
we can use that and patch it if you prefer. The C# support in nix is not that great at this point tbh. |
Ok, I've pushed a new commit. We're now going straight to ckan 1.29.2 and using the provided exe. Please check if it was done properly. Also, @Baughn please check if you still want to be a maintainer for this package or if I shall remove you from the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
gui launches fine
We don't really have any Cake support, patching the distributables is fine for now. |
Please review this for MacOS, I'm not sure if my change breaks that.
Motivation for this change
CKAN is heavily out-of-date
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)