Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to parse signature check as commit timestamp #3932

Merged
merged 1 commit into from Aug 17, 2020
Merged

Don't try to parse signature check as commit timestamp #3932

merged 1 commit into from Aug 17, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Aug 14, 2020 •
edited

Fixes #3933

When the log.showSignature git setting is enabled, the output of
git log contains signature verification information in addition to the
timestamp GitInputScheme::fetch wants:

$ git log -1 --format=%ct
gpg: Signature made Sat 07 Sep 2019 02:02:03 PM PDT
gpg:                using RSA key 0123456789ABCDEF0123456789ABCDEF01234567
gpg:                issuer "user@example.com"
gpg: Good signature from "User <user@example.com>" [ultimate] 1567890123
1567890123

For folks that had log.showSignature set, this caused all nix operations
on flakes to fail:

$ nix build
error: stoull

@chkno
Don't try to parse signature check as commit timestamp
ed026f7 
When the log.showSignature git setting is enabled, the output of
"git log" contains signature verification information in addition to the
timestamp GitInputScheme::fetch wants:

  $ git log -1 --format=%ct
  gpg: Signature made Sat 07 Sep 2019 02:02:03 PM PDT
  gpg:                using RSA key 0123456789ABCDEF0123456789ABCDEF01234567
  gpg:                issuer "user@example.com"
  gpg: Good signature from "User <user@example.com>" [ultimate] 1567890123
  1567890123

For folks that had log.showSignature set, this caused all nix operations
on flakes to fail:

  $ nix build
  error: stoull
@chkno chkno mentioned this pull request Aug 14, 2020
Closed
@edolstra edolstra merged commit e849b19 into NixOS:master Aug 17, 2020
@ldesgoui ldesgoui mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log.showSignature git setting breaks flakes builds
2 participants
@chkno @edolstra