nixos/pulseaudio: Fix ExecStop #95374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just listing previous authors of file: |
|
note that I tested this on NixOS, but I'm the only user on my computers. So I don't know if this will break multi-user computers. |
| @@ -312,6 +312,7 @@ in { | |||
| serviceConfig = { | |||
| Type = "notify"; | |||
| ExecStart = "${binaryNoDaemon} --log-level=${cfg.daemon.logLevel} --system -n --file=${myConfigFile}"; | |||
| ExecStop = "${binaryNoDaemon} --kill"; | |||
There was a problem hiding this comment.
are you using systemWide pulseaudio? Because that isn't the default in nixos and is greatly discouraged in use
(this is in the mkIf systemWide block)
There was a problem hiding this comment.
no, I am not:
hardware.pulseaudio = {
support32Bit = true;
enable = true;
};
There was a problem hiding this comment.
I'll have to do some more investigating.. maybe these changes just coincided with something else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Not sure the root cause, but I will have many pulseaudio daemons running, and unable to get audio.
Current fix was to do
pulseaudio --kill; pulseaudio --start, obviously, this isn't ideal. However, altering the ExecStop to use the--killcommand seems to clean up all the zombie daemons.prior behavior
current behavior:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)