Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fontconfig: Reintroduce unversioned fonts.conf #95362

Merged
merged 1 commit into from Aug 13, 2020
Merged

nixos/fontconfig: Reintroduce unversioned fonts.conf #95362

merged 1 commit into from Aug 13, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 13, 2020 •
edited

Motivation for this change

Turns out lot of software (including Chromium) use bundled fontconfig so we either need to wrap every one of those, or re-introduce the global unversioned config. The latter is easier but weakens hermetic configs. But perhaps those are not really worth the effort.

Closes: #95319

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Successfully ran chromium on unstable with this and f527651 cherry-picked
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar requested a review from flokli August 13, 2020 18:54
@jtojnar jtojnar mentioned this pull request Aug 13, 2020
Merged
10 tasks
@jtojnar
nixos/fontconfig: Reintroduce unversioned fonts.conf
0a4a624 
Turns out lot of software (including Chromium) use bundled fontconfig
so we either need to wrap every one of those, or re-introduce the global unversioned config.
The latter is easier but weakens hermetic configs. But perhaps those are not really worth the effort.
@flokli
Copy link
Contributor

flokli commented Aug 13, 2020

Confirmed this doesn't segfault signal-desktop anymore :-)

@flokli flokli merged commit 6c41fd2 into NixOS:master Aug 13, 2020
@jtojnar jtojnar deleted the global-fc-link branch August 13, 2020 19:48
@SFrijters
Copy link
Member

Same for chromium, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chromium stable 84.0.4147.125 crashes on startup
3 participants
@jtojnar @flokli @SFrijters