[WPT] Add tests for Worker.terminate() during worker script evaluation #25004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 14, 2020
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2355160
branch
5 times, most recently
from
6177adc
to
c60cc88
Compare
workers/Worker-terminate-forever.html terminates workers just after construction, and thus it's likely that the workers are terminated before script evaluation is started. This CL adds Worker-terminate-forever-during-evaluation.html that waits for postMessage(), to ensure the worker is terminated after script evaluation is started. Bug: 1111134, 1129785 Change-Id: I9ebc8effe6234a297e0851042f5de41f611d55aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355160 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808304}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2355160
branch
from
c60cc88
to
fefea06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workers/Worker-terminate-forever.html
terminates workers just after construction, and thus it's likely
that the workers are terminated before script evaluation is started.
This CL adds Worker-terminate-forever-during-evaluation.html
that waits for postMessage(), to ensure the worker is terminated
after script evaluation is started.
Bug: 1111134, 1129785
Change-Id: I9ebc8effe6234a297e0851042f5de41f611d55aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355160
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808304}