Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 52f1ffdb93ab
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f3ba51f1484e
Choose a head ref
  • 2 commits
  • 9 files changed
  • 1 contributor

Commits on Aug 13, 2020

  1. nixos: remove StandardOutput=syslog, StandardError=syslog lines 

    Since systemd 243, docs were already steering users towards using
`journal`:

systemd/systemd@eedaf7f

systemd 246 will go one step further, it shows warnings for these units
during bootup, and will [automatically convert these occurences to
`journal`](systemd/systemd@f3dc6af):

> [    6.955976] systemd[1]: /nix/store/hwyfgbwg804vmr92fxc1vkmqfq2k9s17-unit-display-manager.service/display-manager.service:27: Standard output type syslog is obsolete, automatically updating to journal. Please update│······················
 your unit file, and consider removing the setting altogether.

So there's no point of keeping `syslog` here, and it's probably a better
idea to just not set it, due to:

> This setting defaults to the value set with DefaultStandardOutput= in
> systemd-system.conf(5), which defaults to journal.
    @flokli
    flokli committed Aug 13, 2020
    Copy the full SHA
    962e15a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #95353 from flokli/systemd-output-journal 

    nixos: remove StandardOutput=syslog, StandardError=syslog lines
    @flokli
    flokli committed Aug 13, 2020
    Copy the full SHA
    f3ba51f View commit details
    Browse the repository at this point in the history