vimPlugins.vim-clang-format: init at 2019-05-15 #95366
Conversation
There was a problem hiding this comment.
also, please follow https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs
There should be two commits
pkgs/misc/vim-plugins/overrides.nix
Outdated
| vim-clang-format = super.vim-clang-format.overrideAttrs(old: { | ||
| propagatedBuildInputs = [ clang-tools ]; | ||
| }); |
There was a problem hiding this comment.
I would prefer patching, and avoid adding stuff to a user's path
There was a problem hiding this comment.
ok, tracking.
My experience falls a bit short here, and I didn't see any other examples in overrides.nix of how one would patch in a dependency like that 😅
For simplicity's sake I've opted for just the standard plugin for now, and I'm betting a large majority of users for this plugin will already have clang-format in their environment.
If you're not happy with this approach I'm happy to figure out patching, please point to any docs/examples and I'll got work through it 😄
There was a problem hiding this comment.
Hmm, I can't find any great examples either, but I'm fine with refining it in a different PR.
I think most people will figure out that they need clang-format available for it to work.
maybe propagating is the solution, and I've been reviewing too many python packages
siriobalmelli
force-pushed
the
add/vim-clang-format
branch
from
036bd70
to
c6c0549
Compare
Ok, fixed, thank you. |
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 95366 1
60 packages built:
- vimPlugins.NeoSolarized - vimPlugins.YouCompleteMe - vimPlugins.ale - vimPlugins.coc-fzf - vimPlugins.coc-go - vimPlugins.coc-nvim - vimPlugins.completion-nvim - vimPlugins.conjure - vimPlugins.dart-vim-plugin - vimPlugins.defx-git - vimPlugins.defx-icons - vimPlugins.defx-nvim - vimPlugins.deoplete-fish - vimPlugins.deoplete-jedi - vimPlugins.deoplete-khard - vimPlugins.deoplete-nvim - vimPlugins.fzf-vim - vimPlugins.ghcid - vimPlugins.kotlin-vim - vimPlugins.lh-vim-lib - vimPlugins.lightline-vim - vimPlugins.ncm2-jedi - vimPlugins.neocomplete-vim - vimPlugins.neoterm - vimPlugins.nerdtree - vimPlugins.neuron-vim - vimPlugins.nvim-lsp - vimPlugins.nvim-treesitter - vimPlugins.onedark-vim - vimPlugins.palenight-vim - vimPlugins.syntastic - vimPlugins.unicode-vim - vimPlugins.vim-airline - vimPlugins.vim-bazel - vimPlugins.vim-beancount - vimPlugins.vim-clang-format - vimPlugins.vim-codefmt - vimPlugins.vim-css-color - vimPlugins.vim-devicons - vimPlugins.vim-eunuch - vimPlugins.vim-fireplace - vimPlugins.vim-floaterm - vimPlugins.vim-gitgutter - vimPlugins.vim-go - vimPlugins.vim-maktaba - vimPlugins.vim-monokai - vimPlugins.vim-one - vimPlugins.vim-pandoc-syntax - vimPlugins.vim-plug - vimPlugins.vim-polyglot - vimPlugins.vim-signify - vimPlugins.vim-slime - vimPlugins.vim-snippets - vimPlugins.vim-terraform - vimPlugins.vim-test - vimPlugins.vim-visual-multi - vimPlugins.vim-vsnip - vimPlugins.vim-which-key - vimPlugins.vimtex - vimPlugins.vista-vim
Signed-off-by: Sirio Balmelli sirio@b-ad.ch
Motivation for this change
I daily-drive nixpkgs.neovim on Darwin and Linux, and wanted vim-clang-format plugin
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)