Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nixos-*: use runtimeShell #95367

Merged
merged 1 commit into from Aug 16, 2020
Merged

nixos/nixos-*: use runtimeShell #95367

merged 1 commit into from Aug 16, 2020

Conversation

lopsided98
Copy link
Contributor

This fixes shebangs and other shell uses in the NixOS tools, allowing them to work correctly on cross-compiled systems.

cc @matthewbauer @edolstra

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
nixos/nixos-*: use runtimeShell
f126689 
Fix shebangs and other shell uses in the NixOS tools, allowing them to work
correctly on cross-compiled systems.
@worldofpeace
Copy link
Contributor

@ofborg test installer

@worldofpeace
Copy link
Contributor

@ofborg build nixosTests.installer

@alyssais alyssais merged commit 23b4356 into NixOS:master Aug 16, 2020
@lopsided98 lopsided98 deleted the nixos-tools-shell branch August 16, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @worldofpeace @alyssais