Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mist: remove #95421

Merged
merged 2 commits into from Aug 15, 2020
Merged

mist: remove #95421

merged 2 commits into from Aug 15, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Aug 14, 2020

Motivation for this change

Mist is now deprecated and not maintained anymore since about two years ago.
See README of the repository.

Note that the package in master is also broken (segfault when starting on linux-x86_64).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxalica oxalica requested a review from mmahut as a code owner August 14, 2020 12:09
@drewrisinger
Copy link
Contributor

Diff mostly LGTM, except the alias is a little too long. I'd follow something closer to

nixpkgs/pkgs/top-level/aliases.nix

Line 580 in 8c95378

torch = throw "torch has been removed, as the upstream project has been abandoned"; # added 2020-03-28

If you want, you could still include the migration guide, though people could also find that on their own. I might also move the mist section up to somewhere in the file where it makes a little more sense than directly at the end. maybe somewhere alphabetically.

@oxalica
Copy link
Contributor Author

oxalica commented Aug 15, 2020

Simplified. Now I just put the link to README of the repository, which contains these links.

r? @jonringer

@bhipple bhipple merged commit 04e24aa into NixOS:master Aug 15, 2020
@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Always happy to see garbage being picked up!

@oxalica oxalica deleted the broken-mist branch August 15, 2020 17:28
@jonringer
Copy link
Contributor

I guess i didn't hit submit review, but yea, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxalica @drewrisinger @bhipple @jonringer