-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename incorrectly named vim Dracula plugin #95371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the following commit message:
vimPlugins.dracula: use the correct name for the package
The Dracula plugin for vim seems to be named `vim` due to the automation script. Updating the name of the package to not clash with `vim` itself, and use the appropriate name. https://github.com/dracula/vim/
@prusnak amended the commit message. |
I'm afraid this will be overwritten next time someone updates the package set... We would need to fix the name of the repo itself |
@jonringer Another option would be to special-case the script to avoid using the key |
I think this could lead to some odd behavior, I would like to hear from some others that use vim |
we could change vim-plugin-names format to be able to specify the nix attribute name. This is how I addressed it for the lua ecosystem (see https://github.com/NixOS/nixpkgs/blob/master/maintainers/scripts/luarocks-packages.csv , haskell has a similar .yaml configuration). At some point, we might want to standardize such a configuration file across the different "language packages to nix derivation" ecosystems. |
I think having a mechanism to do some of the renaming makes sense |
@timokau @jonringer Does that mean I should just edit https://github.com/NixOS/nixpkgs/blob/master/pkgs/misc/vim-plugins/vim-plugin-names and submit a new PR? Do I have to run the update script myself or does the build do that? |
you can see there's a similar example:
I would just edit it to say:
and then re-run the update.py |
The Dracula plugin for vim seems to be named
vim
due to the automation script and the structure of the repodracula/vim
. Updating the name of the package to not have a name collision withvim
itself, and use the appropriate name for the plugin. https://github.com/dracula/vim/Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)