Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

papermc: 1.15.2r161 -> 1.16.2r141 #95386

Merged
merged 2 commits into from Aug 25, 2020
Merged

papermc: 1.15.2r161 -> 1.16.2r141 #95386

merged 2 commits into from Aug 25, 2020

Conversation

TheUserCreated
Copy link
Contributor

@TheUserCreated TheUserCreated commented Aug 14, 2020 •
edited

Just updated the version, build number, and sha256 sum

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@TheUserCreated
Update papermc to 1.16.1
967a1e0 
Just updated the version, build number, and sha256 sum
@TheUserCreated TheUserCreated changed the title papermc 1 papermc 1.15.2 to 1.16.1 Aug 14, 2020
@TheUserCreated TheUserCreated changed the title papermc 1.15.2 to 1.16.1 papermc 1.15.2 -> 1.16.1 Aug 14, 2020
@ofborg ofborg bot requested a review from aaronjanse August 14, 2020 01:38
@danieldk danieldk changed the title papermc 1.15.2 -> 1.16.1 papermc: 1.15.2 -> 1.16.1 Aug 14, 2020
danieldk
danieldk suggested changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this update! Could you update the commit message to follow the contribution guidelines?

So, in this case:

papermc: 1.15.2r161 -> 1.16.1r135

@TheUserCreated TheUserCreated changed the title papermc: 1.15.2 -> 1.16.1 papermc: 1.15.2r161 -> 1.16.1r135 Aug 14, 2020
@TheUserCreated
Copy link
Contributor Author

Thank you for submitting this update! Could you update the commit message to follow the contribution guidelines?

So, in this case:

papermc: 1.15.2r161 -> 1.16.1r135

my mistake, didnt think to add the build number. thanks for the heads up

@ghost ghost mentioned this pull request Aug 24, 2020
Closed
10 tasks
@TheUserCreated TheUserCreated changed the title papermc: 1.15.2r161 -> 1.16.1r135 papermc: 1.15.2r161 -> 1.16.2r141 Aug 25, 2020
@TheUserCreated
Copy link
Contributor Author

Unfortunately, this has taken so long to be merged that it is several versions out of date...
I edited to fix that.

danieldk
danieldk approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95386 1

1 package built:
- papermc

@danieldk danieldk merged commit 7dd3f3d into NixOS:master Aug 25, 2020
@TheUserCreated TheUserCreated deleted the patch-1 branch August 25, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@aaronjanse aaronjanse Awaiting requested review from aaronjanse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheUserCreated @danieldk @Janik-Haag