Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune_2: 2.6.2 -> 2.7.0 #95391

Merged
merged 3 commits into from Aug 24, 2020
Merged

dune_2: 2.6.2 -> 2.7.0 #95391

merged 3 commits into from Aug 24, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 14, 2020

Motivation for this change

https://github.com/ocaml/dune/releases/tag/2.7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor Author

marsam commented Aug 14, 2020

@GrahamcOfBorg build flow fstar ocamlformat beluga satysfi

@ofborg ofborg bot requested a review from vbgl August 14, 2020 03:05
@marsam marsam marked this pull request as draft August 14, 2020 03:18
@vbgl
Copy link
Contributor

vbgl commented Aug 14, 2020

There is an easy fix to get dune 2 for OCaml 4.07. Just raise the version number there: https://github.com/NixOS/nixpkgs/blob/4e7fdca34c4bb94470590f02615e56cee97c2d75/pkgs/top-level/ocaml-packages.nix#L221

You should nonetheless raise the minimumOCamlVersion attribute in dune-private-libs.

@marsam marsam force-pushed the update-dune_2 branch 2 times, most recently from 402b744 to 184f905 Compare August 16, 2020 01:34
@marsam
Copy link
Contributor Author

marsam commented Aug 16, 2020

@GrahamcOfBorg build flow fstar ocamlformat beluga satysfi

@marsam marsam marked this pull request as ready for review August 16, 2020 02:46
@marsam
Copy link
Contributor Author

marsam commented Aug 16, 2020

thank you @vbgl for the hint

anmonteiro
anmonteiro reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marsam would you mind also including the dune-glob and dune-action-plugin libraries in this PR?

@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2020

@GrahamcOfBorg build ocamlPackages.dune-action-plugin

@vbgl vbgl merged commit bc00ece into NixOS:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro anmonteiro left review comments

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @vbgl @anmonteiro