odafileconverter: init at 21.7.0.0 #95392
Conversation
There was a problem hiding this comment.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package build on x86_64-linux
- executables tested on x86_64-linux
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - build time only dependencies are declared in
nativeBuildInputs - source is fetched using the appropriate function
- phases are respected
Possible improvements
Please see my comments
Comments
I'm not sure if the package name odafileconverter might be more accurate, but I think this name is fine.
| in mkDerivation { | ||
| pname = "oda-converter"; | ||
| inherit version; |
There was a problem hiding this comment.
Please add a name attribute, such as:
name = "${pname}-${version}";
There was a problem hiding this comment.
Is it necessary? I thought pname + version was all you needed?
There was a problem hiding this comment.
Seems like you're right, sorry. This section of the nixpkg manual made it seem like it is required, but it isn't.
nagisa
changed the title
There was a problem hiding this comment.
All good now from my side. Built & tested on x86_64-linux.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package build on x86_64-linux
- executables tested on x86_64-linux
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - build time only dependencies are declared in
nativeBuildInputs - source is fetched using the appropriate function
- phases are respected
| { lib, stdenv, mkDerivation, dpkg, fetchurl, qtbase }: | ||
|
|
||
| let | ||
| version = "21.7.0.0"; |
There was a problem hiding this comment.
I've been able to find the download link at https://www.opendesign.com/guestfiles/oda_file_converter ; but could you add a comment stating where you found the version number? I can find it nowhere in the page
There was a problem hiding this comment.
They are pretty bad at software distribution honestly speaking. Not only do they not publish the version number (gotta dig for it in the deb metadata) but they also do not maintain stable URI for the past releases.
| wrapQtApp $out/libexec/ODAFileConverter | ||
| mv $out/libexec/ODAFileConverter $out/bin | ||
|
|
||
| find $out/libexec -type f | while read file; do |
There was a problem hiding this comment.
Maybe consider adding -executable, to be more resilient towards future changes?
|
Cool, thank you! |
Motivation for this change
This is the way to convert AutoCAD DWG files to something more open on Linux. It can work both as a stand-alone tool as well as used transparently by freecad and similar tooling to enable DWG support in them.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)