Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aiojobs: init at 0.2.2 #95419

Merged
merged 1 commit into from Aug 18, 2020
Merged

pythonPackages.aiojobs: init at 0.2.2 #95419

merged 1 commit into from Aug 18, 2020

Conversation

CMCDragonkai
Copy link
Member

Motivation for this change

Adds aiojobs for managing asynchronous jobs in asyncio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member Author

This one does have test, and I've added ti!.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95419 1

2 packages built:
- python37Packages.aiojobs
- python38Packages.aiojobs

mweinelt
mweinelt reviewed Aug 14, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments.

pkgs/development/python-modules/aiojobs/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aiojobs/default.nix Show resolved Hide resolved
jonringer
jonringer reviewed Aug 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @mweinelt 's comments are addressed

pkgs/development/python-modules/aiojobs/default.nix Show resolved Hide resolved
jonringer
jonringer reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done with:

git reset HEAD~1                    # move fixup commits (replace number of fixup commits) into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

pkgs/development/python-modules/aiojobs/default.nix Show resolved Hide resolved
pkgs/development/python-modules/aiojobs/default.nix Show resolved Hide resolved
@CMCDragonkai
Copy link
Member Author

All done. Ready to merge.

jonringer
jonringer approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
has tests

https://github.com/NixOS/nixpkgs/pull/95419
2 packages built:
python37Packages.aiojobs python38Packages.aiojobs

@jonringer
Copy link
Contributor

I'll wait for ofborg

@jonringer jonringer merged commit 670c094 into NixOS:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CMCDragonkai @mweinelt @jonringer