Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnunet_git: remove #95413

Merged
merged 1 commit into from Sep 25, 2020
Merged

gnunet_git: remove #95413

merged 1 commit into from Sep 25, 2020

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Aug 14, 2020

Motivation for this change

Quite some time ago gnunet hadn't done any proper releases for a while and you had to follow master to get a decently recent version, so I added this _git package. Since then releases have become much more reliable and this package is no longer needed.

Things done

removed gnunet_git

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor

Maybe add a line to top_level/aliases.nix to either redirect to gnunet, or throw an error that it's no longer available?

@doronbehar
Copy link
Contributor

Pushed the same commit with the alises.

@doronbehar doronbehar merged commit 0c8e51b into NixOS:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pstn @drewrisinger @doronbehar