-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appmenu-gtk-module: init at 0.7.6 #95412
Conversation
@flokli I want two sources. The "fetchFromGitHub" source should only pull a specific directory. |
pkgs/applications/misc/appmenu-gtk-module/80-appmenu-gtk-module
Outdated
Show resolved
Hide resolved
2e15060
to
e527bcd
Compare
I get this weird error doing build regarding "make install":
I can't get my head around why it's trying to write to a nix store of another package: /nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules. Changing "make install" to "make install DESTDIR=output makes it write to "output/nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules" - "make install DESTDIR=./output" gives "./output/nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules" and "make install DESTDIR=$out" gives "/nix/store/b2avnc099m93zsmhlfckdg6303a70nqp-appmenu-gtk-module-0.7.3.2/nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules" |
Because it gets the installation path from pkg-config. Looking at rilian-la-te/vala-panel-appmenu@8867008#diff-cc995e395ef61a60d3fed19e66fe9ca8R42 You should be able to override it by setting |
|
||
meta = with stdenv.lib; { | ||
description = "Port of the Unity GTK Module"; | ||
license = licenses.lgpl3Only; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see the outcome of this.
e527bcd
to
966e6d4
Compare
I changed the package to use "meson" and inserting the "PKG_CONFIG_GTK__3_0_LIBDIR" string but it stil tries to install in a wrong store path:
|
That is the gtk2 module. You will need to set similar environment for that. |
966e6d4
to
72642e4
Compare
@jtojnar
Somehow the right appmenu module has to get loaded (either gtk2 or gtk3 depending on the application). |
We use |
Also it looks like you accidentally dropped the changes. |
4367e82
to
475b6c1
Compare
They should be included again. |
475b6c1
to
6e623d6
Compare
The module's schema is actually linked into |
The schema is likely in a subdirectory to avoid conflicts. For programs, the wrapper adds the subdirectory to |
You're right. I suppose, going the way of glib-networking and patching this library to hardcode the schema path would be the optimal way. |
Hello, I too am waiting for this to be merged.
Did somebody managed to make it work with Gimp and/or Ardour ? Best regards, |
Didn't get this to work with gimp on archlinux too, not sure if it should There should be gtk2 version of this package too |
It may be just that, I might look into it in the coming days. I know I made kde global menu works using unity-gtk-module on Ubuntu just a few months ago. It worked for Gimp and most GTK apps I can think of. The exact instructions I followed for Ubuntu can be found on this reddit post. Not sure if this information can help here or not :). |
It needs to be re-worked. In the current state, the PR only adds this library/module but doesn't make it visible to other GTK apps. |
9f67ff3
to
e1b510c
Compare
e1b510c
to
e93d481
Compare
e93d481
to
ae3bad3
Compare
I got this to build now with MATE Terminal and have changed to the correct license. @Vivien-lelouette GIMP stable is still based on GTK2 hence appmenu-gtk3 will not work. |
''; | ||
|
||
meta = with lib; { | ||
description = "Port of the Unity GTK 3 Module"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing homepage
meson | ||
cmake | ||
pkg-config | ||
systemd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
systemd is normally not used in nativeBuildInputs. You are sure about this?
Any news on this? I would also be very interested in getting this into Nixpkgs. |
Needed to get an appmenu on KDE for a lot of GTK apps like FireDragon, I think. Stolen from the already existing PR NixOS/nixpkgs#95412, which sadly didn't have much traction lately. --------- Co-authored-by: Pedro Lara Campos <root@pedrohlc.com>
replaced by linked PR |
Am I missing something? Which PR are you talking about? |
This one: chaotic-cx/nyx#33 |
Sure, this one adds it. But it's on Chaotic Nyx and not Nixpkgs itself, therefore I don't understand why it "replaces" this PR. |
When using Plasma 5 under NixOS 23.11 with an added appmenu most gtk3 apps seems to be already supported which seems to be due to "libappindicator-gtk3" being installed. |
That's how it looksI have my taskbar on the top of the screen, and there is the global menu to the right of start menu button. That is, this application menu is being rendered on the taskbar.
|
Motivation for this change
appmenu-gtk-module is currently not in nix as a separate package despite being compatible with a wide range of DEs.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)