appmenu-gtk-module: init at 0.7.6 #95412

LouisDK1 · 2020-08-14T10:40:29Z

Motivation for this change

appmenu-gtk-module is currently not in nix as a separate package despite being compatible with a wide range of DEs.

Things done

LouisDK1 · 2020-08-14T10:49:24Z

@flokli I want two sources. The "fetchFromGitHub" source should only pull a specific directory.
I've used this as an example to follow: https://github.com/NixOS/nixpkgs/tree/master/pkgs/desktops/xfce/panel-plugins/xfce4-vala-panel-appmenu-plugin but somehow my syntax is wrong.

pkgs/applications/misc/appmenu-gtk-module/80-appmenu-gtk-module

pkgs/applications/misc/appmenu-gtk-module/default.nix

LouisDK1 · 2020-08-16T16:38:04Z

@flokli

I get this weird error doing build regarding "make install":

-- Install configuration: "Release"
-- Installing: /nix/store/94xqbvpvr10srsygydjbwj61kvb8238x-appmenu-gtk-module-0.7.3.2/share/glib-2.0/schemas/org.appmenu.gtk-module.gschema.xml
-- Compiling GSettings schemas
-- Installing: /nix/store/94xqbvpvr10srsygydjbwj61kvb8238x-appmenu-gtk-module-0.7.3.2/lib/pkgconfig/appmenu-gtk3-parser.pc
-- Installing: /nix/store/94xqbvpvr10srsygydjbwj61kvb8238x-appmenu-gtk-module-0.7.3.2/lib/libappmenu-gtk3-parser.so.0
-- Installing: /nix/store/94xqbvpvr10srsygydjbwj61kvb8238x-appmenu-gtk-module-0.7.3.2/lib/libappmenu-gtk3-parser.so
-- Installing: /nix/store/94xqbvpvr10srsygydjbwj61kvb8238x-appmenu-gtk-module-0.7.3.2/include/appmenu-gtk-parser/appmenu-gtk-parser.h
-- Installing: /nix/store/94xqbvpvr10srsygydjbwj61kvb8238x-appmenu-gtk-module-0.7.3.2/include/appmenu-gtk-parser/appmenu-gtk-menu-shell.h
-- Installing: /nix/store/94xqbvpvr10srsygydjbwj61kvb8238x-appmenu-gtk-module-0.7.3.2/include/appmenu-gtk-parser/appmenu-gtk-action-group.h
CMake Error at src/cmake_install.cmake:60 (file):
file cannot create directory:
/nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules.
Maybe need administrative privileges.
Call Stack (most recent call first):
cmake_install.cmake:49 (include)

make: *** [Makefile:105: install] Error 1
builder for '/nix/store/hb6wkqch2f4fnm5lcvrv7l025m8xfcyk-appmenu-gtk-module-0.7.3.2.drv' failed with exit code 2
cannot build derivation '/nix/store/3m1v0zh5rn9i5axnq61n3zfpdiv888i5-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lcka3p95xjns9i7d5lkk6zxzbg5axf6i-nixos-system-louis-t25-20.09.git.e527bcd4615M.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lcka3p95xjns9i7d5lkk6zxzbg5axf6i-nixos-system-louis-t25-20.09.git.e527bcd4615M.drv' failed

I can't get my head around why it's trying to write to a nix store of another package: /nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules.

Changing "make install" to "make install DESTDIR=output makes it write to "output/nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules" - "make install DESTDIR=./output" gives "./output/nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules" and "make install DESTDIR=$out" gives "/nix/store/b2avnc099m93zsmhlfckdg6303a70nqp-appmenu-gtk-module-0.7.3.2/nix/store/jh3g99wnj2k7gcr8mh8cgz1jhs16br3s-gtk+3-3.24.21/lib/gtk-3.0/modules"

jtojnar · 2020-08-16T18:02:33Z

Because it gets the installation path from pkg-config.

Looking at

rilian-la-te/vala-panel-appmenu@8867008#diff-cc995e395ef61a60d3fed19e66fe9ca8R42
rilian-la-te/vala-panel-appmenu@8867008#diff-2e797d7dc74fd47eb280e1b101cf2105R5

You should be able to override it by setting PKG_CONFIG_GTK__3_0_LIBDIR = "${placeholder "out"}/lib";. That is if you use meson and ninja. (not sure if cmake uses the same but Meson is nicer anyway.)

pkgs/applications/misc/appmenu-gtk-module/default.nix

jtojnar · 2020-08-16T18:19:44Z

pkgs/applications/misc/appmenu-gtk-module/default.nix

+
+  meta = with stdenv.lib; {
+    description = "Port of the Unity GTK Module";
+    license = licenses.lgpl3Only;


https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/331

Let's see the outcome of this.

LouisDK1 · 2020-08-17T09:19:20Z

@jtojnar

You should be able to override it by setting PKG_CONFIG_GTK__3_0_LIBDIR = "${placeholder "out"}/lib";. That is if you use meson and ninja. (not sure if cmake uses the same but Meson is nicer anyway.)

I changed the package to use "meson" and inserting the "PKG_CONFIG_GTK__3_0_LIBDIR" string but it stil tries to install in a wrong store path:

[0/1] Installing files.
Installing lib/libappmenu-gtk2-parser.so.0.7 to /nix/store/dypzf6m7zm3v8bjr8fg1mbnn8zzaxh3h-appmenu-gtk-module-0.7.3.2/lib
Installing lib/libappmenu-gtk3-parser.so.0.7 to /nix/store/dypzf6m7zm3v8bjr8fg1mbnn8zzaxh3h-appmenu-gtk-module-0.7.3.2/lib
Installing src/gtk-2.0/libappmenu-gtk-module.so to /nix/store/g9pfp91b5syf8qpp5hv8pqwyaca1k0v8-gtk+-2.24.32/lib/gtk-2.0/modules
Traceback (most recent call last):
File "/nix/store/03ynlqzgvwn9ilm798hpps46b4nw4fv0-meson-0.55.0/lib/python3.8/site-packages/mesonbuild/mesonmain.py", line 131, in run
return options.run_func(options)
File "/nix/store/03ynlqzgvwn9ilm798hpps46b4nw4fv0-meson-0.55.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 542, in run
installer.do_install(datafilename)
File "/nix/store/03ynlqzgvwn9ilm798hpps46b4nw4fv0-meson-0.55.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 362, in do_install
self.install_targets(d)
File "/nix/store/03ynlqzgvwn9ilm798hpps46b4nw4fv0-meson-0.55.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 470, in install_targets
file_copied = self.do_copyfile(fname, outname, makedirs=(d.dirmaker, outdir))
File "/nix/store/03ynlqzgvwn9ilm798hpps46b4nw4fv0-meson-0.55.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 276, in do_copyfile
shutil.copyfile(from_file, to_file)
File "/nix/store/fjgnz0xfl04hsblsi4ym5y5akfh6mlmy-python3-3.8.5/lib/python3.8/shutil.py", line 261, in copyfile
with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
PermissionError: [Errno 13] Permission denied: '/nix/store/g9pfp91b5syf8qpp5hv8pqwyaca1k0v8-gtk+-2.24.32/lib/gtk-2.0/modules/libappmenu-gtk-module.so'

jtojnar · 2020-08-17T12:29:05Z

That is the gtk2 module. You will need to set similar environment for that.

pkgs/applications/misc/appmenu-gtk-module/default.nix

LouisDK1 · 2020-08-18T18:59:10Z

@jtojnar
I got my last commit to build successfully but starting an GTK3 application supporting appmenu like Mate terminal gave this error:

(mate-terminal:4179): Gtk-WARNING **: 20:34:49.300: GTK+ module /run/current-system/sw/lib/gtk-2.0/modules/libappmenu-gtk-module.so cannot be loaded.
GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported.
Gtk-Message: 20:34:49.300: Failed to load module "appmenu-gtk-module"

Somehow the right appmenu module has to get loaded (either gtk2 or gtk3 depending on the application).
Under Arch Linux this works so I suspect that this issue might be related to the way NixOS is linking libraries and which one are loaded by the application in question but I'm no expert on this.

jtojnar · 2020-08-18T20:14:40Z

We use GTK_PATH environment variable for both GTK 2 and GTK 3. @worldofpeace do you remember how does GTK choose matching version of modules?

jtojnar · 2020-08-18T20:15:15Z

Also it looks like you accidentally dropped the changes.

LouisDK1 · 2020-08-18T21:59:37Z

@jtojnar

Also it looks like you accidentally dropped the changes.

They should be included again.

greydot · 2022-05-11T18:31:42Z

Adding this module as dependency to every package would be overkill

I think correct solution here should be
{
  environment.pathsToLink = ["/share/gsettings-schemas"];
}
Or writing module, which will add it to XDG_DATA_DIRS directly

The module's schema is actually linked into /run/current-system/sw/share, which is in $XDG_DATA_DIRS. I have no clue why glib/gtk can't pick it up and I haven't debugged any further.

jtojnar · 2022-05-11T23:14:10Z

The schema is likely in a subdirectory to avoid conflicts. For programs, the wrapper adds the subdirectory to XDG_DATA_DIRS but that obviously does not apply to libraries.

greydot · 2022-05-12T13:11:24Z

The schema is likely in a subdirectory to avoid conflicts. For programs, the wrapper adds the subdirectory to XDG_DATA_DIRS but that obviously does not apply to libraries.

You're right. I suppose, going the way of glib-networking and patching this library to hardcode the schema path would be the optimal way.

Vivien-lelouette · 2022-09-28T13:16:16Z

Hello,

I too am waiting for this to be merged.
In the mean time, I added the package to my configuration (see this file on my repo). In this file, I added the fixes talked about in this comment of @CertainLach.
It works on VirtManager, but not on Gimp or Ardour with the following error:

GTK+ module /run/current-system/sw/lib/gtk-3.0/modules/libappmenu-gtk-module.so cannot be loaded.
GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported.

Did somebody managed to make it work with Gimp and/or Ardour ?
Also, is this PR still alive ?

Best regards,
Lelouette Vivien.

CertainLach · 2022-09-29T03:29:05Z

Didn't get this to work with gimp on archlinux too, not sure if it should

There should be gtk2 version of this package too

Vivien-lelouette · 2022-09-29T04:31:19Z

It may be just that, I might look into it in the coming days.

I know I made kde global menu works using unity-gtk-module on Ubuntu just a few months ago. It worked for Gimp and most GTK apps I can think of.

The exact instructions I followed for Ubuntu can be found on this reddit post. Not sure if this information can help here or not :).

greydot · 2022-10-02T10:54:20Z

Also, is this PR still alive ?

It needs to be re-worked. In the current state, the PR only adds this library/module but doesn't make it visible to other GTK apps.

LouisDK1 · 2022-11-29T21:14:29Z

I got this to build now with MATE Terminal and have changed to the correct license.

@Vivien-lelouette GIMP stable is still based on GTK2 hence appmenu-gtk3 will not work.

SuperSandro2000 · 2023-02-22T10:01:27Z

pkgs/development/libraries/appmenu-gtk3-module/default.nix

+  '';
+
+  meta = with lib; {
+    description = "Port of the Unity GTK 3 Module";


Missing homepage

SuperSandro2000 · 2023-02-22T10:01:47Z

pkgs/development/libraries/appmenu-gtk3-module/default.nix

+    meson
+    cmake
+    pkg-config
+    systemd


systemd is normally not used in nativeBuildInputs. You are sure about this?

dr460nf1r3 · 2023-04-12T19:20:02Z

Any news on this? I would also be very interested in getting this into Nixpkgs.

Needed to get an appmenu on KDE for a lot of GTK apps like FireDragon, I think. Stolen from the already existing PR NixOS/nixpkgs#95412, which sadly didn't have much traction lately. --------- Co-authored-by: Pedro Lara Campos <root@pedrohlc.com>

SuperSandro2000 · 2023-04-26T21:18:11Z

replaced by linked PR

dr460nf1r3 · 2023-04-27T07:47:49Z

Am I missing something? Which PR are you talking about?

LouisDK1 · 2023-08-23T17:24:54Z

Am I missing something? Which PR are you talking about?

This one: chaotic-cx/nyx#33

dr460nf1r3 · 2023-08-24T11:51:03Z

Sure, this one adds it. But it's on Chaotic Nyx and not Nixpkgs itself, therefore I don't understand why it "replaces" this PR.

LouisDK1 · 2023-11-22T19:27:53Z

Sure, this one adds it. But it's on Chaotic Nyx and not Nixpkgs itself, therefore I don't understand why it "replaces" this PR.

When using Plasma 5 under NixOS 23.11 with an added appmenu most gtk3 apps seems to be already supported which seems to be due to "libappindicator-gtk3" being installed.
Do you have any examples of other gtk3 apps not supporting the appmenu?

CertainLach · 2024-04-01T10:27:11Z

seems to be due to "libappindicator-gtk3" being installed.

libappindicator is for tray support, while appmenu-gtk3-module is about global menu.

That's how it looks

I have my taskbar on the top of the screen, and there is the global menu to the right of start menu button. That is, this application menu is being rendered on the taskbar.

Do you have any examples of other gtk3 apps not supporting the appmenu?

xournalpp, virt-manager, mate-terminal packages only have the global menu when appmenu-gtk-module is installed, so this is still relevant for plasma6 on NixOS master.

flokli requested changes Aug 15, 2020

View reviewed changes

LouisDK1 force-pushed the appmenu-gtk-module branch from 2e15060 to e527bcd Compare August 16, 2020 16:26

flokli requested review from jtojnar and worldofpeace August 16, 2020 17:55

flokli added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 16, 2020

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 16, 2020

jtojnar reviewed Aug 16, 2020

View reviewed changes

pkgs/applications/misc/appmenu-gtk-module/default.nix Outdated Show resolved Hide resolved

jtojnar reviewed Aug 16, 2020

View reviewed changes

LouisDK1 force-pushed the appmenu-gtk-module branch from e527bcd to 966e6d4 Compare August 17, 2020 09:13

ofborg bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 17, 2020

jtojnar reviewed Aug 17, 2020

View reviewed changes

pkgs/applications/misc/appmenu-gtk-module/default.nix Outdated Show resolved Hide resolved

jtojnar reviewed Aug 17, 2020

View reviewed changes

pkgs/applications/misc/appmenu-gtk-module/default.nix Outdated Show resolved Hide resolved

LouisDK1 force-pushed the appmenu-gtk-module branch from 966e6d4 to 72642e4 Compare August 18, 2020 18:48

LouisDK1 force-pushed the appmenu-gtk-module branch 3 times, most recently from 4367e82 to 475b6c1 Compare August 18, 2020 21:57

LouisDK1 force-pushed the appmenu-gtk-module branch from 475b6c1 to 6e623d6 Compare August 19, 2020 11:59

LouisDK1 force-pushed the appmenu-gtk-module branch from 9f67ff3 to e1b510c Compare November 28, 2022 22:38

LouisDK1 changed the title ~~[wip] appmenu-gtk-module: init at 0.7.6~~ appmenu-gtk-module: init at 0.7.6 Nov 28, 2022

LouisDK1 marked this pull request as ready for review November 28, 2022 22:46

LouisDK1 force-pushed the appmenu-gtk-module branch from e1b510c to e93d481 Compare November 29, 2022 20:49

appmenu-gtk3-module: init at 7.6

ae3bad3

LouisDK1 force-pushed the appmenu-gtk-module branch from e93d481 to ae3bad3 Compare November 29, 2022 20:54

LouisDK1 changed the title ~~appmenu-gtk-module: init at 0.7.6~~ [wip] appmenu-gtk-module: init at 0.7.6 Nov 29, 2022

LouisDK1 changed the title ~~[wip] appmenu-gtk-module: init at 0.7.6~~ appmenu-gtk-module: init at 0.7.6 Nov 29, 2022

LouisDK1 requested review from flokli and removed request for worldofpeace November 29, 2022 23:09

SuperSandro2000 reviewed Feb 22, 2023

View reviewed changes

dr460nf1r3 mentioned this pull request Apr 15, 2023

appmenu-gtk3-module: init at 0.7.6 chaotic-cx/nyx#33

Merged

SuperSandro2000 closed this Apr 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

appmenu-gtk-module: init at 0.7.6 #95412

appmenu-gtk-module: init at 0.7.6 #95412

LouisDK1 commented Aug 14, 2020 •

edited

LouisDK1 commented Aug 14, 2020

LouisDK1 commented Aug 16, 2020

jtojnar commented Aug 16, 2020

jtojnar Aug 16, 2020

LouisDK1 Aug 17, 2020

LouisDK1 commented Aug 17, 2020

jtojnar commented Aug 17, 2020

LouisDK1 commented Aug 18, 2020

jtojnar commented Aug 18, 2020

jtojnar commented Aug 18, 2020

LouisDK1 commented Aug 18, 2020

greydot commented May 11, 2022 •

edited

jtojnar commented May 11, 2022

greydot commented May 12, 2022

Vivien-lelouette commented Sep 28, 2022 •

edited

CertainLach commented Sep 29, 2022 •

edited

Vivien-lelouette commented Sep 29, 2022 •

edited

greydot commented Oct 2, 2022 •

edited

LouisDK1 commented Nov 29, 2022 •

edited

SuperSandro2000 Feb 22, 2023

SuperSandro2000 Feb 22, 2023

dr460nf1r3 commented Apr 12, 2023

SuperSandro2000 commented Apr 26, 2023

dr460nf1r3 commented Apr 27, 2023

LouisDK1 commented Aug 23, 2023

dr460nf1r3 commented Aug 24, 2023

LouisDK1 commented Nov 22, 2023

CertainLach commented Apr 1, 2024

appmenu-gtk-module: init at 0.7.6 #95412

appmenu-gtk-module: init at 0.7.6 #95412

Conversation

LouisDK1 commented Aug 14, 2020 • edited

Motivation for this change

Things done

LouisDK1 commented Aug 14, 2020

LouisDK1 commented Aug 16, 2020

jtojnar commented Aug 16, 2020

jtojnar Aug 16, 2020

Choose a reason for hiding this comment

LouisDK1 Aug 17, 2020

Choose a reason for hiding this comment

LouisDK1 commented Aug 17, 2020

jtojnar commented Aug 17, 2020

LouisDK1 commented Aug 18, 2020

jtojnar commented Aug 18, 2020

jtojnar commented Aug 18, 2020

LouisDK1 commented Aug 18, 2020

greydot commented May 11, 2022 • edited

jtojnar commented May 11, 2022

greydot commented May 12, 2022

Vivien-lelouette commented Sep 28, 2022 • edited

CertainLach commented Sep 29, 2022 • edited

Vivien-lelouette commented Sep 29, 2022 • edited

greydot commented Oct 2, 2022 • edited

LouisDK1 commented Nov 29, 2022 • edited

SuperSandro2000 Feb 22, 2023

Choose a reason for hiding this comment

SuperSandro2000 Feb 22, 2023

Choose a reason for hiding this comment

dr460nf1r3 commented Apr 12, 2023

SuperSandro2000 commented Apr 26, 2023

dr460nf1r3 commented Apr 27, 2023

LouisDK1 commented Aug 23, 2023

dr460nf1r3 commented Aug 24, 2023

LouisDK1 commented Nov 22, 2023

CertainLach commented Apr 1, 2024

LouisDK1 commented Aug 14, 2020 •

edited

greydot commented May 11, 2022 •

edited

Vivien-lelouette commented Sep 28, 2022 •

edited

CertainLach commented Sep 29, 2022 •

edited

Vivien-lelouette commented Sep 29, 2022 •

edited

greydot commented Oct 2, 2022 •

edited

LouisDK1 commented Nov 29, 2022 •

edited