Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.transformers: enable on all Unix platforms #94702

Closed
wants to merge 2 commits into from
Closed

python3Packages.transformers: enable on all Unix platforms #94702

wants to merge 2 commits into from

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 5, 2020

Motivation for this change

Draft to check that transformers builds on AArch64 (Darwin checked locally). Requires merge and rebase of #94700 first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor Author

danieldk commented Aug 5, 2020

@ofborg build python37Packages.transformers python38Packages.transformers

@danieldk
Copy link
Contributor Author

danieldk commented Aug 5, 2020

@ofborg build python37Packages.transformers python38Packages.transformers

@ofborg ofborg bot requested a review from vcunat August 5, 2020 07:38
@danieldk
Copy link
Contributor Author

danieldk commented Aug 5, 2020

@ofborg build python37Packages.transformers python38Packages.transformers

@danieldk
Copy link
Contributor Author

danieldk commented Aug 5, 2020

@ofborg build python37Packages.transformers python38Packages.transformers

@danieldk danieldk removed the request for review from vcunat August 8, 2020 08:03
@danieldk
Copy link
Contributor Author

danieldk commented Aug 8, 2020

@ofborg build python37Packages.transformers python38Packages.transformers

@danieldk danieldk closed this Aug 8, 2020
@danieldk danieldk deleted the transformers-unix branch August 8, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danieldk