Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element-web, element-desktop: 1.7.2 -> 1.7.3 #94745

Merged
merged 2 commits into from Aug 5, 2020
Merged

element-web, element-desktop: 1.7.2 -> 1.7.3 #94745

merged 2 commits into from Aug 5, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 5, 2020 •
edited

Motivation for this change

Two security problems.

  • Element Web 1.7.3 (as well as the earlier release 1.7.2) fixes an issue where replying to a specially formatted message would make it seem like the replier said something they did not. Thanks to Sorunome for responsibly disclosing this via Matrix's Security Disclosure Policy.

  • Element Web 1.7.3 (as well as the earlier release 1.7.2) fixes an issue where an unexpected language ID in a code block could cause Element to crash. Thanks to SakiiR for responsibly disclosing this via Matrix's Security Disclosure Policy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 5, 2020

Result of nixpkgs-review pr 94745 1

2 packages built:
- element-desktop
- element-web

@mweinelt mweinelt requested a review from Ma27 August 5, 2020 18:06
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 5, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 5, 2020

Please also backport to stable as soon as this is merged.

@Ma27 Ma27 merged commit a317c62 into NixOS:master Aug 5, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 5, 2020

Thanks! Ported to stable as 5580251, f80b8d1.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 5, 2020
@mweinelt mweinelt deleted the element branch August 5, 2020 20:13
@Ma27 Ma27 mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @Ma27