Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build elementary-files with vala 0.48 #94711

Closed
wants to merge 3 commits into from
Closed

build elementary-files with vala 0.48 #94711

wants to merge 3 commits into from

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Aug 5, 2020

Motivation for this change

fixes #94707

There is probably a more elegant way to do it but this was the one with the least impact I could find.

ping @vcunat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pstn pstn changed the title Fix elementary vala build elementary-files with vala 0.48 Aug 5, 2020
@ofborg ofborg bot added the 6.topic: pantheon The Pantheon desktop environment label Aug 5, 2020
@pstn
Copy link
Contributor Author

pstn commented Aug 5, 2020

I don't know why @GrahamcOfBorg fails here. It builds for me locally just fine.

@vcunat
Copy link
Member

vcunat commented Aug 5, 2020

Most likely because of --arg config { allowAliases = false; }

@worldofpeace
Copy link
Contributor

We actually need to update vala on stable in the 0.46 series which is completely fine for a stable release.
Once I've verified that works I'm going to revert the update on release-20.03 and merge the vala update to staging-20.03.
And then "revert the revert" on that branch as well.

@worldofpeace worldofpeace mentioned this pull request Aug 5, 2020
Closed
@worldofpeace
Copy link
Contributor

fixed in caf8427.

@worldofpeace worldofpeace mentioned this pull request Aug 5, 2020
Merged
10 tasks
@worldofpeace
Copy link
Contributor

Here's the PR that updates vala and reverts that revert #94749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pstn @vcunat @worldofpeace @hedning