Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: 0.4.3 -> 0.4.4 #94705

Merged
merged 1 commit into from Aug 5, 2020
Merged

neovim: 0.4.3 -> 0.4.4 #94705

merged 1 commit into from Aug 5, 2020

Conversation

yoctocell
Copy link
Member

@yoctocell yoctocell commented Aug 5, 2020 •
edited

Motivation for this change

Update to newset release https://github.com/neovim/neovim/releases/tag/v0.4.4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yoctocell yoctocell changed the title <!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions --> neovim: 0.4.3 -> 0.4.4 Aug 5, 2020
@ofborg ofborg bot requested review from Ma27 and manveru August 5, 2020 08:38
@mweinelt
Copy link
Member

mweinelt commented Aug 5, 2020

Result of nixpkgs-review pr 94705 1

3 packages built:
- gnvim
- neovim-qt
- neovim-unwrapped

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 5, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 5, 2020

After looking at the changelog which is basically a list of bugfixes, I think that we should backport this to 20.03.

Ma27
Ma27 approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally and tested against my setup 👍

@Ma27 Ma27 merged commit 71ca3bf into NixOS:master Aug 5, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 5, 2020

Thanks! Ported to stable as e0c983e.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@Ma27 Ma27 Ma27 approved these changes

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yoctocell @mweinelt @Ma27