Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Apply patch for CVE-2019-20907 #94703

Merged
merged 1 commit into from Aug 11, 2020
Merged

python: Apply patch for CVE-2019-20907 #94703

merged 1 commit into from Aug 11, 2020

Conversation

ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Aug 5, 2020

Motivation for this change

Patch issue directly instead of waiting for a new point release since I doubt that there will be another release for Python 2.7. Including the patch file in tree because the upstream patch target is Python 3 not Python 2.

Needs backport to 20.03.

Re #94004

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions -> Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ckauhaus ckauhaus requested a review from FRidh as a code owner August 5, 2020 07:23
@FRidh
Copy link
Member

FRidh commented Aug 5, 2020 •
edited

Please use git format-patch on python/cpython@1fa6ef2 if possible, so we keep the original authorship.

@ckauhaus
Copy link
Contributor Author

ckauhaus commented Aug 5, 2020

will do

python: Apply patch for CVE-2019-20907
dd8e524 
Incluing the patch file in-tree because the upstream patch is not
intended to apply for Python 2.

Re NixOS#94004
@ckauhaus ckauhaus force-pushed the 94004-python-cve-2019-20907 branch from 5238bf1 to dd8e524 Compare August 7, 2020 14:27
@ckauhaus
Copy link
Contributor Author

ckauhaus commented Aug 7, 2020

@FRidh better?

@FRidh FRidh self-assigned this Aug 7, 2020
@ckauhaus
Copy link
Contributor Author

@FRidh would perhaps be a good idea to merge this into staging not master due to the large rebuild set

@FRidh FRidh changed the base branch from master to staging August 11, 2020 14:05
@FRidh FRidh merged commit a14859c into NixOS:staging Aug 11, 2020
@ckauhaus ckauhaus deleted the 94004-python-cve-2019-20907 branch August 11, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckauhaus @FRidh