I reviewed this PR.

If anybody else wants to review- here are the steps:

	disabledModules = [
		# "virtualisation/virtualbox-host.nix"
		"services/ttys/kmscon.nix"
	];
	imports =
	[
		<LOCALCHECKOUT>/nixos/modules/services/ttys/kmscon.nix"
        ]

       # IMPORT THIS PR AS A NIXPKG AND IN THE ABOVE LOCAL CHECKOUT, REPLACE THE PACAKGE

Review, source

1. Hashes of both libtsm and kmscon match the implied source address
2. libtsm no longer builds on darwin, although I'm not sure why it used to since rg'ing through nixpkgs tells me that kmscon was the sole user (removed patch and buildinputs)
3. libtsm no longer has --disable-debug flag fro configure
4. kmscon removes patch, I verified in the new source that the two lines are as in the patch, iterate until SIGSYS, and an extra #include.

This looks good, so long as @peterhoeg did (3) deliberately. Also, perhaps add to meta.description a variation of "Updated fork of KMSCon, a KMS/DRM based system console" to clarify that this is no longer an "official" work...? I'm not sure of the best practice here really, so feel free to ignore this point.

Review, usage:

I was able to use kmscon in my tty, and the following things worked:

• (Beautiful, as always) non-latin fonts
• scrollback
• zoom

Good to go. I can test anything else if any regular user has suggestions.

This looks good, so long as @peterhoeg did (3) deliberately.

Yep. libtsm is now built with cmake that handles this for us (and besides configureFlags have no effect on cmake)

Also, perhaps add to meta.description a variation of "Updated fork of KMSCon, a KMS/DRM based system console" to clarify that this is no longer an "official" work...?

We change upstream every now and then which normally isn't reflected in the description as it doesn't really add much.

Thanks for the thorough review @asdf8dfafjk. Much appreciated!