Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gperftools: fix dlopen() of gperftools on AArch64 #94704

Merged
merged 1 commit into from Aug 8, 2020
Merged

gperftools: fix dlopen() of gperftools on AArch64 #94704

merged 1 commit into from Aug 8, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 5, 2020 •
edited

Motivation for this change

The sentencepiece Python module cannot be build on AArch64 due to an error cannot allocate memory in static TLS block:

https://hydra.nixos.org/build/124772579/nixlog/1

See also:

https://bugzilla.redhat.com/show_bug.cgi?id=1483558

This change uses a patch from Fedora to disable generic dynamic TLS on
AArch32/64.

(Since this requires autoreconfHook, maybe it's worthwhile switching to fetchFromGitHub as well?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vcunat August 5, 2020 08:16
@danieldk
gperftools: fix dlopen() of gperftools on AArch64
66d9d73 
dlopen()'ing gperftools results in "cannot allocate memory in static TLS
block", see:

https://bugzilla.redhat.com/show_bug.cgi?id=1483558

This change uses a patch from Fedora to disable generic dynamic TLS on
AArch32/64.
@danieldk danieldk changed the title gperftools: fix dlopen() of gperftools AArch64 gperftools: fix dlopen() of gperftools on AArch64 Aug 5, 2020
@danieldk
Copy link
Contributor Author

danieldk commented Aug 7, 2020

@vcunat any objections against merging this?

vcunat
vcunat approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, though it would be nicer if they were integrating such things upstream.

@vcunat vcunat merged commit 564f440 into NixOS:master Aug 8, 2020
@danieldk danieldk deleted the gperf-tools-aarch64-tls branch August 8, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @vcunat