New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.03] Firefox 79 #94746
[20.03] Firefox 79 #94746
Conversation
012b5dc
to
0b4ff85
Compare
0b4ff85
to
0c700a5
Compare
I am getting a segfault when trying to execute this on nixos-unstable. Just before the crash it spits out an error about fontconfig. I guess that might be a fontconfig and/or glibc upgrade that broke compat with the running system? That being said test are running just fine. |
@@ -53,7 +55,7 @@ | |||
|
|||
# dependencies requires for stable backports | |||
|
|||
, rust-cbindgen_0_14_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nitpick: SInce we are touching these lines how about we merge this block with the one above at line 19-22? Would be more consistent and we wouldn't have two "blocks" for backports :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides that one nitpick this looks fine. I assume the segfault I got (outside of the nixos test) was from some incompat between unstable (my current system channel) and 20.03.
(cherry picked from commit 6a4e0ee)
0c700a5
to
74ddece
Compare
Done. |
Successfully built this, and ran the firefox VM test. |
cc @vcunat @andir @taku0
Thunderbird
is still compiling,seems to work fine.Although we could actually just not compile it with the newer rust.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)