Fieldset NG: Support dynamic changes of properties copied to anonymous fieldset content box #24884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 5, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2336565
branch
2 times, most recently
from
5d3c53e
to
6763739
Compare
fieldset content box LayoutNGFieldset should adopt LayoutObject::UpdateAnonymousChildStyle() to update properties correctly. Also, we need to add kFlowRoot support to LayoutBlock::CreateAnonymousWithParentAndDisplay(). Bug: 875235 Change-Id: I8601f1c576c8ee818e69d43dc299026a03879ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336565 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795306}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2336565
branch
from
6763739
to
2a451d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutNGFieldset should adopt LayoutObject::UpdateAnonymousChildStyle()
to update properties correctly. Also, we need to add kFlowRoot support
to LayoutBlock::CreateAnonymousWithParentAndDisplay().
Bug: 875235
Change-Id: I8601f1c576c8ee818e69d43dc299026a03879ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336565
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795306}